From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AE0FC388F9 for ; Fri, 23 Oct 2020 11:16:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D16BA2192A for ; Fri, 23 Oct 2020 11:16:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1603451798; bh=3TifcDjPRxrSi9sq/0otIVA8a/Qa5urRtEfBTn9Pfhk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=0R3TkJFFSwts4Gm198OIfED22140+w7tqxQPf4udMCYkgPDdNFqSAfPqPACP/AvL8 sf5TWt9UcmpJZK8kiHaHZNWnwpWOtR/Bds11EzoDs1Y6exboAyMN2IfGhR+Tx1qWy2 U0JlHzlbTV1M7/vtS2L0JnIVV0vKD6PpWh8Li2no= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S462805AbgJWLQi (ORCPT ); Fri, 23 Oct 2020 07:16:38 -0400 Received: from mail-ej1-f65.google.com ([209.85.218.65]:34846 "EHLO mail-ej1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S462757AbgJWLQh (ORCPT ); Fri, 23 Oct 2020 07:16:37 -0400 Received: by mail-ej1-f65.google.com with SMTP id p5so1860069ejj.2; Fri, 23 Oct 2020 04:16:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=I7tXxZpGoreg85HA0VUxkudPh8npM8uC5nLxLgLNurw=; b=cM3Z4sytLTIjLxEXkNvyBil5R8nHzT/o2Yat1OZfrvDefqeNUpfdDlillmtt+lCgR/ KDxKxbPrKWl5elWiA30ol7GPxUCCxoek/zC/qGugbGIB5G00Xg8ySmCeMjxMJ1R9N1L7 BoXRjDclAga4WhMmgqCFgjTKYWwfX+yXI6YtU8bJ+IrrvFMy6yJOVAwMhFN7B3uFTPOM XlhWSojXPM+nzCVa4ypWaIBUG2e21dXTirZ5D5MvgjSuzQNGzE6VxZD/h4RMXCx7HAP3 0ODXZ6CuBiMiDSuReGbo+hPxuz96UMrxmnv1e5iI7NYtbgPkzF2LILErWSVMpfWq9JEB yJOQ== X-Gm-Message-State: AOAM5338zadOGz07tyZRCLrstk127x5qDgCjq05GOkistM7gqxQVpo7/ 0aRaC0satQ0jByGWtkcNusI= X-Google-Smtp-Source: ABdhPJzoA3+2dyw0HIdiALYHcsoNfM039rsAqi/Wc+Hi2TMGcbUlUhwbDTGeU1VWf0IsmpGbG0mD6Q== X-Received: by 2002:a17:906:a04c:: with SMTP id bg12mr1373658ejb.317.1603451795423; Fri, 23 Oct 2020 04:16:35 -0700 (PDT) Received: from kozik-lap ([194.230.155.171]) by smtp.googlemail.com with ESMTPSA id ao17sm666245ejc.18.2020.10.23.04.16.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Oct 2020 04:16:34 -0700 (PDT) Date: Fri, 23 Oct 2020 13:16:32 +0200 From: Krzysztof Kozlowski To: Adam Ford Cc: arm-soc , Adam Ford-BE , Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree , Linux Kernel Mailing List Subject: Re: [PATCH] arm64: dts: imx: Add Beacon i.MX8M Nano development kit Message-ID: <20201023111632.GB48162@kozik-lap> References: <20201022165751.771695-1-aford173@gmail.com> <20201023094437.GB42872@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Oct 23, 2020 at 05:51:56AM -0500, Adam Ford wrote: > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts b/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts > > > new file mode 100644 > > > index 000000000000..faa55d888065 > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/freescale/imx8mn-beacon-kit.dts > > > @@ -0,0 +1,19 @@ > > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > > > +/* > > > + * Copyright 2020 Compass Electronics Group, LLC > > > + */ > > > + > > > +/dts-v1/; > > > + > > > +#include "imx8mn.dtsi" > > > +#include "imx8mn-beacon-som.dtsi" > > > +#include "imx8mn-beacon-baseboard.dtsi" > > > > Why do you need baseboard as DTSI? Is is separate than kit? Judging by > > contents look like just empty/fake DTS and the baseboard should be the > > DTS. > > > > Another hint: Baseboard also does not have its compatible, so it cannot > > exist in real life separate from the development kit... > > The baseboard can handle two separate, mutually exclusive video > outputs. It has a LVDS bridge chip and an HDMI bridge chip, but > without the DSI and LCDIF support, neither can function. > Right now, that LVDS chip doesn't have an upstream driver, but I plan > to introduce it once the LCDIF, and DSI interfaces are available and > functional. > > Once there is video support, the kit-level DTS file will get support > for one of the video outputs, and a second DTS file will get created > to support the other. Both of these kit-level files would include the > baseboard and SOM DTSI files since they would be common to both kits. Sounds good. > > > > + > > > +/ { > > > + model = "Beacon EmbeddedWorks i.MX8M Mini Development Kit"; > > > + compatible = "beacon,imx8mn-beacon-kit", "fsl,imx8mn"; > > > > Undocumented compatible. > > I am still trying to learn the YAML rules. Do I just add it to the > fsl.yaml? 'beacon' is in the vendor-prefixes, but I looked and the > 'imx8mm-beacon-kit' which is already in the kernel doesn't have a > compatible either and they are virtually identical. Enough will be adding it to the fsl.yaml. There is no strict need for separate compatible for baseboard, although that's quite common practice since you want to reuse it. The beacon,imx8mm-beacon-kit is in fsl.yaml, so you can just duplicate for imx8mn. Best regards, Krzysztof