From: Andrew Lunn <andrew@lunn.ch>
To: Adam Sampson <ats@offog.org>
Cc: linux-sunxi@googlegroups.com, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY
Date: Sun, 25 Oct 2020 17:34:29 +0100 [thread overview]
Message-ID: <20201025163429.GH792004@lunn.ch> (raw)
In-Reply-To: <20201025140144.28693-1-ats@offog.org>
On Sun, Oct 25, 2020 at 02:01:44PM +0000, Adam Sampson wrote:
> The RX/TX delays for the Ethernet PHY on the Linksprite pcDuino 3 Nano
> are configured in hardware, using resistors that are populated to pull
> the RTL8211E's RXDLY/TXDLY pins low or high as needed.
>
> phy-mode should be set to rgmii-id to reflect this. Previously it was
> set to rgmii, which used to work but now results in the delays being
> disabled again as a result of the bugfix in commit bbc4d71d6354 ("net:
> phy: realtek: fix rtl8211e rx/tx delay config").
>
> Tested on two pcDuino 3 Nano boards purchased in 2015. Without this fix,
> Ethernet works unreliably on one board and doesn't work at all on the
> other.
>
> Fixes: 061035d456c9 ("ARM: dts: sun7i: Add dts file for pcDuino 3 Nano board")
> Signed-off-by: Adam Sampson <ats@offog.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
next prev parent reply other threads:[~2020-10-25 16:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-25 14:01 [PATCH] ARM: dts: sun7i: pcduino3-nano: enable RGMII RX/TX delay on PHY Adam Sampson
2020-10-25 16:34 ` Andrew Lunn [this message]
2020-11-23 4:42 ` [linux-sunxi] " Chen-Yu Tsai
2020-11-23 11:48 ` Maxime Ripard
-- strict thread matches above, loose matches on Subject: below --
2020-11-23 17:47 Adam Sampson
2020-11-24 14:24 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201025163429.GH792004@lunn.ch \
--to=andrew@lunn.ch \
--cc=ats@offog.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-sunxi@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).