From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Martin Jücker" <martin.juecker@gmail.com>
Cc: linux-samsung-soc@vger.kernel.org, kgene@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/5] ARM: dts: add Samsung's exynos4412-based p4note boards
Date: Mon, 26 Oct 2020 17:00:23 +0100 [thread overview]
Message-ID: <20201026160023.GA120575@kozik-lap> (raw)
In-Reply-To: <20201026144830.GA76312@kozik-lap>
On Mon, Oct 26, 2020 at 03:48:30PM +0100, Krzysztof Kozlowski wrote:
> On Sat, Oct 24, 2020 at 04:44:18PM +0200, Martin Jücker wrote:
(...)
> > +&i2c_7 {
> > + samsung,i2c-sda-delay = <100>;
> > + samsung,i2c-slave-addr = <0x10>;
> > + samsung,i2c-max-bus-freq = <400000>;
> > + pinctrl-0 = <&i2c7_bus>;
> > + pinctrl-names = "default";
> > + status = "okay";
> > +
> > + max77686: max77686_pmic@9 {
> > + compatible = "maxim,max77686";
> > + interrupt-parent = <&gpx0>;
> > + interrupts = <7 IRQ_TYPE_NONE>;
> > + pinctrl-0 = <&max77686_irq>;
> > + pinctrl-names = "default";
> > + reg = <0x09>;
> > + #clock-cells = <1>;
> > +
> > + voltage-regulators {
>
> Just "regulators" and no empty line after this.
Skip this comment, it's obviously wrong, as the regulator driver and
bindings require the exact name "voltage-regulator".
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-10-26 16:02 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-24 14:44 [PATCH 0/5] add exynos4412-based p4note device family support Martin Jücker
2020-10-24 14:44 ` [PATCH 1/5] dt-bindings: samsung: document bindings for p4note family boards Martin Jücker
2020-10-30 18:28 ` Rob Herring
2020-10-24 14:44 ` [PATCH 2/5] ARM: dts: add Samsung's exynos4412-based p4note boards Martin Jücker
2020-10-26 11:55 ` Marek Szyprowski
2020-10-26 14:48 ` Krzysztof Kozlowski
2020-10-26 16:00 ` Krzysztof Kozlowski [this message]
2020-10-26 23:27 ` Martin Juecker
2020-10-27 8:17 ` Krzysztof Kozlowski
2020-10-29 21:40 ` Martin Juecker
2020-10-30 7:41 ` Marek Szyprowski
2020-10-24 14:44 ` [PATCH 3/5] ARM: defconfig: add stmpe adc driver for p4note Martin Jücker
2020-10-24 14:44 ` [PATCH 4/5] ARM: defconfig: compile Atmel MXT touchscreeen as module Martin Jücker
2020-10-24 14:44 ` [PATCH 5/5] ARM: exynos: extend cpuidle support to p4note boards Martin Jücker
-- strict thread matches above, loose matches on Subject: below --
2020-10-31 17:58 [PATCH v2 0/5] add exynos4412-based p4note device family support Martin Jücker
2020-10-31 17:58 ` [PATCH 2/5] ARM: dts: add Samsung's exynos4412-based p4note boards Martin Jücker
2020-11-02 19:18 ` Krzysztof Kozlowski
2020-11-02 21:21 ` Martin Juecker
2020-11-03 7:53 ` Krzysztof Kozlowski
2020-11-03 9:51 ` Marek Szyprowski
2020-11-03 10:38 ` Martin Juecker
2020-11-05 11:50 ` Marek Szyprowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201026160023.GA120575@kozik-lap \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=martin.juecker@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).