From: Nishanth Menon <nm@ti.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: Tero Kristo <t-kristo@ti.com>, <devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
Swapnil Jakhade <sjakhade@cadence.com>,
Kishon Vijay Abraham I <kishon@ti.com>
Subject: Re: [PATCH 2/4] arm64: dts: ti: k3-j721e-common-proc-board: add DP to j7 evm
Date: Tue, 27 Oct 2020 10:14:07 -0500 [thread overview]
Message-ID: <20201027151407.7c2arettxvly5fhh@cross> (raw)
In-Reply-To: <5e095a0b-9369-c15b-f00c-ec5b2b27b870@ti.com>
On 16:44-20201027, Tomi Valkeinen wrote:
> On 27/10/2020 14:20, Nishanth Menon wrote:
> > On 12:41-20201027, Tomi Valkeinen wrote:
> > [...]
> >
> >> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> >> index 52e121155563..5a36d65755ee 100644
> >> --- a/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> >> +++ b/arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts
> >> @@ -83,6 +83,31 @@ sound0: sound@0 {
> >> "cpb-codec-scki",
> >> "cpb-codec-scki-48000", "cpb-codec-scki-44100";
> >> };
> >> +
> >> + dp_pwr_3v3: fixedregulator-dp-prw {
> >> + compatible = "regulator-fixed";
> >> + regulator-name = "dp-pwr";
> >> + regulator-min-microvolt = <3300000>;
> >> + regulator-max-microvolt = <3300000>;
> >> + gpio = <&exp4 0 0>; /* P0 - DP0_PWR_SW_EN */
> >> + enable-active-high;
> >> +
> >> + /* Always on for now, until dp-connector driver can handle this */
> >> + regulator-always-on;
> >> + };
> >> +
> >> + dp0: connector {
> >> + compatible = "dp-connector";
> >
> > This is not documented? I see the following on checkpatch:
> > +WARNING: DT compatible string "dp-connector" appears un-documented -- check ./Documentation/devicetree/bindings/
> > +#42: FILE: arch/arm64/boot/dts/ti/k3-j721e-common-proc-board.dts:100:
> > ++ compatible = "dp-connector";
> > + mechanically convert to the typical style using --fix or --fix-inplace.
> > + them to the maintainer, see CHECKPATCH in MAINTAINERS.
>
> Yes, I mentioned this in the cover letter.
>
Aaah thanks. We may need to look at reposting this patch after it hits mainline.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
next prev parent reply other threads:[~2020-10-27 16:52 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 10:41 [PATCH 0/4] arm64: dts: ti: AM6 and J721e display dts changes Tomi Valkeinen
2020-10-27 10:41 ` [PATCH 1/4] arm64: dts: ti: k3-j721e-main: add DP & DP PHY Tomi Valkeinen
2020-10-27 12:40 ` Nishanth Menon
2020-10-27 10:41 ` [PATCH 2/4] arm64: dts: ti: k3-j721e-common-proc-board: add DP to j7 evm Tomi Valkeinen
2020-10-27 12:20 ` Nishanth Menon
2020-10-27 14:44 ` Tomi Valkeinen
2020-10-27 15:14 ` Nishanth Menon [this message]
2020-10-27 10:41 ` [PATCH 3/4] arm64: dts: ti: k3-am65: mark dss as dma-coherent Tomi Valkeinen
2020-10-27 12:34 ` Nishanth Menon
2020-10-27 14:45 ` Tomi Valkeinen
2020-10-27 15:14 ` Nishanth Menon
2020-10-27 10:41 ` [PATCH 4/4] arm64: dts: ti: am654-base-board: fix clock node name Tomi Valkeinen
2020-10-27 12:39 ` Nishanth Menon
2020-10-27 14:55 ` Tomi Valkeinen
2020-10-27 15:24 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201027151407.7c2arettxvly5fhh@cross \
--to=nm@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=sjakhade@cadence.com \
--cc=t-kristo@ti.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox