* [PATCH] arm64: dts: qcom: sm8250: remove wakeup-parent for TLMM node
@ 2020-10-27 1:54 Dmitry Baryshkov
2020-10-28 4:40 ` Bjorn Andersson
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Baryshkov @ 2020-10-27 1:54 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson
Cc: linux-arm-msm, Manivannan Sadhasivam, Rob Herring, devicetree
On SM8250 TLMM doesn't use PDC interrupt controller for wakeup events.
Instead it handles them on their own (not implemented yet). In addition
setting wakeup-parent property to &pdc will result in parent hwirq being
set to ~0UL, which interact badly with the irqdomains trimming code. So
remove the wakeup-parent property.
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Fixes: 16951b490b20 ("arm64: dts: qcom: sm8250: Add TLMM pinctrl node")
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index ccbdb47d6119..77ea20421752 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2418,7 +2418,6 @@ tlmm: pinctrl@f100000 {
interrupt-controller;
#interrupt-cells = <2>;
gpio-ranges = <&tlmm 0 0 180>;
- wakeup-parent = <&pdc>;
pri_mi2s_sck_active: pri-mi2s-sck-active {
mux {
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8250: remove wakeup-parent for TLMM node
2020-10-27 1:54 [PATCH] arm64: dts: qcom: sm8250: remove wakeup-parent for TLMM node Dmitry Baryshkov
@ 2020-10-28 4:40 ` Bjorn Andersson
2020-10-28 11:52 ` Dmitry Baryshkov
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Andersson @ 2020-10-28 4:40 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, linux-arm-msm, Manivannan Sadhasivam, Rob Herring,
devicetree
On Mon 26 Oct 20:54 CDT 2020, Dmitry Baryshkov wrote:
> On SM8250 TLMM doesn't use PDC interrupt controller for wakeup events.
> Instead it handles them on their own (not implemented yet). In addition
> setting wakeup-parent property to &pdc will result in parent hwirq being
> set to ~0UL, which interact badly with the irqdomains trimming code. So
> remove the wakeup-parent property.
>
Would you accept this patch instead?
https://lore.kernel.org/r/20201028043642.1141723-1-bjorn.andersson@linaro.org
Regards,
Bjorn
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> Fixes: 16951b490b20 ("arm64: dts: qcom: sm8250: Add TLMM pinctrl node")
> ---
> arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> index ccbdb47d6119..77ea20421752 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
> @@ -2418,7 +2418,6 @@ tlmm: pinctrl@f100000 {
> interrupt-controller;
> #interrupt-cells = <2>;
> gpio-ranges = <&tlmm 0 0 180>;
> - wakeup-parent = <&pdc>;
>
> pri_mi2s_sck_active: pri-mi2s-sck-active {
> mux {
> --
> 2.28.0
>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] arm64: dts: qcom: sm8250: remove wakeup-parent for TLMM node
2020-10-28 4:40 ` Bjorn Andersson
@ 2020-10-28 11:52 ` Dmitry Baryshkov
2020-11-03 17:40 ` Bjorn Andersson
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Baryshkov @ 2020-10-28 11:52 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, linux-arm-msm, Manivannan Sadhasivam, Rob Herring,
devicetree
On 28/10/2020 07:40, Bjorn Andersson wrote:
> On Mon 26 Oct 20:54 CDT 2020, Dmitry Baryshkov wrote:
>
>> On SM8250 TLMM doesn't use PDC interrupt controller for wakeup events.
>> Instead it handles them on their own (not implemented yet). In addition
>> setting wakeup-parent property to &pdc will result in parent hwirq being
>> set to ~0UL, which interact badly with the irqdomains trimming code. So
>> remove the wakeup-parent property.
>>
>
> Would you accept this patch instead?
>
> https://lore.kernel.org/r/20201028043642.1141723-1-bjorn.andersson@linaro.org
not found
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sm8250: remove wakeup-parent for TLMM node
2020-10-28 11:52 ` Dmitry Baryshkov
@ 2020-11-03 17:40 ` Bjorn Andersson
2020-11-03 23:53 ` Dmitry Baryshkov
0 siblings, 1 reply; 6+ messages in thread
From: Bjorn Andersson @ 2020-11-03 17:40 UTC (permalink / raw)
To: Dmitry Baryshkov
Cc: Andy Gross, linux-arm-msm, Manivannan Sadhasivam, Rob Herring,
devicetree
On Wed 28 Oct 06:52 CDT 2020, Dmitry Baryshkov wrote:
> On 28/10/2020 07:40, Bjorn Andersson wrote:
> > On Mon 26 Oct 20:54 CDT 2020, Dmitry Baryshkov wrote:
> >
> > > On SM8250 TLMM doesn't use PDC interrupt controller for wakeup events.
> > > Instead it handles them on their own (not implemented yet). In addition
> > > setting wakeup-parent property to &pdc will result in parent hwirq being
> > > set to ~0UL, which interact badly with the irqdomains trimming code. So
> > > remove the wakeup-parent property.
> > >
> >
> > Would you accept this patch instead?
> >
> > https://lore.kernel.org/r/20201028043642.1141723-1-bjorn.andersson@linaro.org
>
> not found
>
Seems like the tubes where slow last week, but the link works now.
Please take a look and let me know if this works better for you.
Thanks,
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sm8250: remove wakeup-parent for TLMM node
2020-11-03 17:40 ` Bjorn Andersson
@ 2020-11-03 23:53 ` Dmitry Baryshkov
2020-11-04 1:09 ` Bjorn Andersson
0 siblings, 1 reply; 6+ messages in thread
From: Dmitry Baryshkov @ 2020-11-03 23:53 UTC (permalink / raw)
To: Bjorn Andersson
Cc: Andy Gross, open list:DRM DRIVER FOR MSM ADRENO GPU,
Manivannan Sadhasivam, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
Hello,
On Tue, 3 Nov 2020 at 20:40, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
>
> On Wed 28 Oct 06:52 CDT 2020, Dmitry Baryshkov wrote:
>
> > On 28/10/2020 07:40, Bjorn Andersson wrote:
> > > On Mon 26 Oct 20:54 CDT 2020, Dmitry Baryshkov wrote:
> > >
> > > > On SM8250 TLMM doesn't use PDC interrupt controller for wakeup events.
> > > > Instead it handles them on their own (not implemented yet). In addition
> > > > setting wakeup-parent property to &pdc will result in parent hwirq being
> > > > set to ~0UL, which interact badly with the irqdomains trimming code. So
> > > > remove the wakeup-parent property.
> > > >
> > >
> > > Would you accept this patch instead?
> > >
> > > https://lore.kernel.org/r/20201028043642.1141723-1-bjorn.andersson@linaro.org
> >
> > not found
> >
>
> Seems like the tubes where slow last week, but the link works now.
> Please take a look and let me know if this works better for you.
I will check this patch. However note, that we need to get 5.10 fixed
wrt TLMM irqs. And the mentioned patch probably doesn't stand a chance
of being merged into 5.10-rc, does it?
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sm8250: remove wakeup-parent for TLMM node
2020-11-03 23:53 ` Dmitry Baryshkov
@ 2020-11-04 1:09 ` Bjorn Andersson
0 siblings, 0 replies; 6+ messages in thread
From: Bjorn Andersson @ 2020-11-04 1:09 UTC (permalink / raw)
To: Dmitry Baryshkov, linus.walleij
Cc: Andy Gross, open list:DRM DRIVER FOR MSM ADRENO GPU,
Manivannan Sadhasivam, Rob Herring,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS
On Tue 03 Nov 17:53 CST 2020, Dmitry Baryshkov wrote:
> Hello,
>
> On Tue, 3 Nov 2020 at 20:40, Bjorn Andersson <bjorn.andersson@linaro.org> wrote:
> >
> > On Wed 28 Oct 06:52 CDT 2020, Dmitry Baryshkov wrote:
> >
> > > On 28/10/2020 07:40, Bjorn Andersson wrote:
> > > > On Mon 26 Oct 20:54 CDT 2020, Dmitry Baryshkov wrote:
> > > >
> > > > > On SM8250 TLMM doesn't use PDC interrupt controller for wakeup events.
> > > > > Instead it handles them on their own (not implemented yet). In addition
> > > > > setting wakeup-parent property to &pdc will result in parent hwirq being
> > > > > set to ~0UL, which interact badly with the irqdomains trimming code. So
> > > > > remove the wakeup-parent property.
> > > > >
> > > >
> > > > Would you accept this patch instead?
> > > >
> > > > https://lore.kernel.org/r/20201028043642.1141723-1-bjorn.andersson@linaro.org
> > >
> > > not found
> > >
> >
> > Seems like the tubes where slow last week, but the link works now.
> > Please take a look and let me know if this works better for you.
>
> I will check this patch. However note, that we need to get 5.10 fixed
> wrt TLMM irqs. And the mentioned patch probably doesn't stand a chance
> of being merged into 5.10-rc, does it?
>
If the driver is broken in v5.10-rc and my patch fixes the problem we
should make a case for that and I'm sure Linus Walleij will consider
picking it up as a -rc fix.
Regards,
Bjorn
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-11-04 1:09 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-10-27 1:54 [PATCH] arm64: dts: qcom: sm8250: remove wakeup-parent for TLMM node Dmitry Baryshkov
2020-10-28 4:40 ` Bjorn Andersson
2020-10-28 11:52 ` Dmitry Baryshkov
2020-11-03 17:40 ` Bjorn Andersson
2020-11-03 23:53 ` Dmitry Baryshkov
2020-11-04 1:09 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).