From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB334C4363A for ; Wed, 28 Oct 2020 23:08:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9477420791 for ; Wed, 28 Oct 2020 23:08:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ffwll.ch header.i=@ffwll.ch header.b="Oj55s1u+" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727329AbgJ1XId (ORCPT ); Wed, 28 Oct 2020 19:08:33 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33902 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725797AbgJ1XIc (ORCPT ); Wed, 28 Oct 2020 19:08:32 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F183BC0613CF for ; Wed, 28 Oct 2020 16:08:31 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id h22so816639wmb.0 for ; Wed, 28 Oct 2020 16:08:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:mail-followup-to:references :mime-version:content-disposition:in-reply-to; bh=WLWDWfUn62HuyKL78MLrBuM1P4gEN0IVPMugnmjyIpc=; b=Oj55s1u+HirbuDDCtgGf2TCwNQs1t7Hb/dfEAbtoX4rp6Vi9YOyYi0ZR6vyFEJnv46 srMzjKdpNzPMuK/b/uwsPoV8xLsInM+031sEoA5Uns+jUhqfFFLnA1zctrfKyId7XHGc IbDB6x5ghe+8hsKenVf6Dwci2fYo3m0yskyWc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=WLWDWfUn62HuyKL78MLrBuM1P4gEN0IVPMugnmjyIpc=; b=lJkOdOaS8Q0h/zqcMvfIfDMJL1wOky2ifJJT6afYr+LjZYR6j3tPbJmysjjJiHq4CO VZpK0JJEV7OwB95GEJs8VpbOiBSzy1kN2iwiojj4yuGA6uVOPOl9uqdX/AyN9ANwXQPV onqQoshIOKSNeJ6ZrvqkrbhwD1KVogeVCQHFogR2Cs07JXwccruTYY/ZmoKgePgHPpfG xtd1PkgwrMQK3uKk0n0dF0B9bQAoxT7MrMyotJ9dySzdlWNFVaM4+D551SuTxb5kg3TC GufqX69loy1bGTbCUs0e7tjWnPio1nabdkRgk3NK14JJPAKdT0iu9WGTFGcrsOQ5aoZA QmtA== X-Gm-Message-State: AOAM530tWzitRATf+azeKXV1WgVCOVzxkELHjAzJT73F1y4tCzjD5TuP yuOC1o5Y9OeiNaL8P2bKYl0XboyAeMYeEZT2 X-Google-Smtp-Source: ABdhPJz+EU8YlisomHF2zSjkLF+2zPf9qTQiMauCyQazYiNEgL02k8jKGZP/kZkcr+tV3wxSwpQU7g== X-Received: by 2002:a7b:cbc8:: with SMTP id n8mr7567498wmi.186.1603884560710; Wed, 28 Oct 2020 04:29:20 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id g5sm5698229wmi.4.2020.10.28.04.29.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Oct 2020 04:29:19 -0700 (PDT) Date: Wed, 28 Oct 2020 12:29:17 +0100 From: Daniel Vetter To: Maxime Ripard Cc: Hoegeun Kwon , eric@anholt.net, airlied@linux.ie, daniel@ffwll.ch, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, dave.stevenson@raspberrypi.com, sungguk.na@samsung.com Subject: Re: [PATCH 1/1] drm/vc4: drv: Add error handding for bind Message-ID: <20201028112917.GW401619@phenom.ffwll.local> Mail-Followup-To: Maxime Ripard , Hoegeun Kwon , eric@anholt.net, airlied@linux.ie, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, dave.stevenson@raspberrypi.com, sungguk.na@samsung.com References: <20201027041442.30352-1-hoegeun.kwon@samsung.com> <20201027041442.30352-2-hoegeun.kwon@samsung.com> <20201027145431.zasv2oiydglz3n63@gilmour.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201027145431.zasv2oiydglz3n63@gilmour.lan> X-Operating-System: Linux phenom 5.7.0-1-amd64 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Oct 27, 2020 at 03:54:31PM +0100, Maxime Ripard wrote: > Hi, > > On Tue, Oct 27, 2020 at 01:14:42PM +0900, Hoegeun Kwon wrote: > > There is a problem that if vc4_drm bind fails, a memory leak occurs on > > the drm_property_create side. Add error handding for drm_mode_config. > > > > Signed-off-by: Hoegeun Kwon > > Applied, thanks! Switching over to drmm_ version of this would also be good I think. Together with the devm_ version for allocating the drm_device you could delete a pile of that fragile cleanup code. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch