From: Geert Uytterhoeven <geert+renesas@glider.be>
To: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>,
"Zhang Rui" <rui.zhang@intel.com>,
"Daniel Lezcano" <daniel.lezcano@linaro.org>,
"Amit Kucheria" <amitk@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>
Cc: linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Amit Kucheria <amit.kucheria@linaro.org>,
Rob Herring <robh@kernel.org>
Subject: [PATCH v3] dt-bindings: thermal: rcar-thermal: Improve schema validation
Date: Wed, 28 Oct 2020 16:35:41 +0100 [thread overview]
Message-ID: <20201028153541.1736279-1-geert+renesas@glider.be> (raw)
- Factor out common required properties,
- "interrupts", "clocks", and "power-domains" are required on R-Mobile
APE6, too,
- Invert logic to simplify descriptions.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
v3:
- Rebase on top of commit 5be478f9c24fbdf8 ("dt-bindings: Another
round of adding missing 'additionalProperties'"),
v2:
- Add Reviewed-by.
---
.../bindings/thermal/rcar-thermal.yaml | 48 +++++++++++--------
1 file changed, 29 insertions(+), 19 deletions(-)
diff --git a/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml b/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml
index 7e9557ac0e4a011c..927de79ab4b56e37 100644
--- a/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml
+++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.yaml
@@ -62,25 +62,35 @@ properties:
"#thermal-sensor-cells":
const: 0
-if:
- properties:
- compatible:
- contains:
- enum:
- - renesas,thermal-r8a73a4 # R-Mobile APE6
- - renesas,thermal-r8a7779 # R-Car H1
-then:
- required:
- - compatible
- - reg
-else:
- required:
- - compatible
- - reg
- - interrupts
- - clocks
- - power-domains
- - resets
+required:
+ - compatible
+ - reg
+
+allOf:
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - renesas,thermal-r8a73a4 # R-Mobile APE6
+ - renesas,thermal-r8a7779 # R-Car H1
+ then:
+ required:
+ - resets
+ - '#thermal-sensor-cells'
+
+ - if:
+ not:
+ properties:
+ compatible:
+ contains:
+ const: renesas,thermal-r8a7779 # R-Car H1
+ then:
+ required:
+ - interrupts
+ - clocks
+ - power-domains
additionalProperties: false
--
2.25.1
next reply other threads:[~2020-10-29 0:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 15:35 Geert Uytterhoeven [this message]
2020-11-12 11:32 ` [PATCH v3] dt-bindings: thermal: rcar-thermal: Improve schema validation Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028153541.1736279-1-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=amit.kucheria@linaro.org \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).