From: Rob Herring <robh@kernel.org>
To: Sameer Pujar <spujar@nvidia.com>
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3 1/3] ASoC: dt-bindings: audio-graph-card: switch to yaml base Documentation
Date: Wed, 28 Oct 2020 11:04:27 -0500 [thread overview]
Message-ID: <20201028160427.GA4094628@bogus> (raw)
In-Reply-To: <eba1f18a-0b2e-d52b-593a-9ef5304f9199@nvidia.com>
On Tue, Oct 27, 2020 at 11:33:49AM +0530, Sameer Pujar wrote:
> Hi Morimoto-san,
>
> > > > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > > >
> > > > This patch switches from .txt base to .yaml base Document.
> > > >
> > > > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > (snip)
> > > Since I am trying to re-use most of audio-graph for Tegra, can
> > > 'compatible' be moved to a separate schema?
> > > For example,
> > > audio-graph.yaml -> defines all the common stuff
> > > audio-graph-card.yaml -> audio-graph.yaml + 'compatible' property
> > > Similarly, tegra-audio-graph-card.yaml -> audio-graph.yaml + Tegra
> > > 'compatible' property
> > I'm not expert of Json-Schema, and it sound very expert technique for me.
> > (It always indicates me unknown errors...)
> > I'm posting this patch since many month ago, and not yet accepted
> > for many reasons (audio-graph DT is very complex).
> > I spend many times for it and finally come to the point where it
> > can (might) be accepted.
> > I'm sorry but I want to finish this work,
> > this means I don't want to customize it any more.
> > If I try it, it needs more month...
>
> I am not a json-schema expert either :) From earlier comments on Tegra audio
> graph series, above re-use is possible I suppose. I depend on your
> audio-graph documentation and for 'compatible' I am seeing error. So I
> thought it may be fine to split audio-graph into two json-schemas now
> itself. Otherwise I need to do it separately in my series if I want to
> re-use your audio-graph, which is fine with me.
I think this part must be sorted out. Defining the graph schema could
come later though.
With compatible dropped from audio-graph.yaml,
audio-graph-scu-card.yaml would look like this:
allOf:
- $ref: audio-graph.yaml
properties:
compatible:
const: audio-graph-scu-card
unevaluatedProperties: false
However, What is 'audio-graph-scu-card' supposed to mean compared to
'audio-graph-card'. It's never used by the driver or in any dts file.
Rob
next prev parent reply other threads:[~2020-10-29 2:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 0:45 [PATCH v3 0/3] ASoC: dt-bindings: audio-graph-card: switch to yaml base Documentation Kuninori Morimoto
2020-10-22 0:46 ` [PATCH v3 1/3] " Kuninori Morimoto
2020-10-22 5:19 ` Sameer Pujar
2020-10-27 4:52 ` Kuninori Morimoto
2020-10-27 6:15 ` Sameer Pujar
2020-10-27 5:32 ` Kuninori Morimoto
2020-10-27 6:03 ` Sameer Pujar
2020-10-28 16:04 ` Rob Herring [this message]
2020-10-28 23:33 ` Kuninori Morimoto
2020-10-23 13:52 ` Sameer Pujar
2020-10-25 23:07 ` Kuninori Morimoto
2020-10-26 2:49 ` Sameer Pujar
2020-10-27 5:22 ` Kuninori Morimoto
2020-10-22 0:46 ` [PATCH v3 2/3] ASoC: dt-bindings: renesas,rsnd: " Kuninori Morimoto
2020-10-23 16:06 ` [PATCH v3 2/3] ASoC: dt-bindings: renesas, rsnd: " Rob Herring
2020-10-22 0:46 ` [PATCH v3 3/3] dt-bindings: ASoC: renesas,rsnd: Add r8a77961 support Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201028160427.GA4094628@bogus \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=spujar@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).