From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CF822C4363A for ; Thu, 29 Oct 2020 00:39:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7A1C02076B for ; Thu, 29 Oct 2020 00:39:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="a0s8idfn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729552AbgJ2Aji (ORCPT ); Wed, 28 Oct 2020 20:39:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388785AbgJ2Aje (ORCPT ); Wed, 28 Oct 2020 20:39:34 -0400 Received: from mail-pf1-x443.google.com (mail-pf1-x443.google.com [IPv6:2607:f8b0:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 69EE4C0613D2 for ; Wed, 28 Oct 2020 17:39:34 -0700 (PDT) Received: by mail-pf1-x443.google.com with SMTP id o129so905016pfb.1 for ; Wed, 28 Oct 2020 17:39:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ZedC2vigvm5YIn/fNFp5FXPUqakrWVfWwG+npbhFrco=; b=a0s8idfnoRHJpK/+DESXypox99Vruk0+O4DxZW30HW8gOKipZ0aPYM4b6SdecDlU5u FVXRZje7gGtILOMRJEDC4r/0++H2soJ7X2pBGgjQBi/Lt/Qx6BoCqLgHwO8ITqSrDgl4 YQ5cRpMxtT/xxtSGhwB7gw9nr+A2yLv1+jVLM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ZedC2vigvm5YIn/fNFp5FXPUqakrWVfWwG+npbhFrco=; b=HXlQklRsvTFWvSEg7dcQNHVU7/9jWK+pRWc/K1rHKtNi0DtxIhgjPdl3cElqY4/Vp2 kYkBAHxJTUtqg6ftMabo17gZjn38yCqq7OS32RAiAdTuxgyORAaQeD0afKl1BfngLCWx DnkXRorAYrlxLhag2VUtvQl/Tg/n7nb4YlGTF9BAtFWbkg/d197BPxx6SDmxK8mEJf6u XT3m9WeFEyzEyrRC6kZW3LA5QanLIU3/gElu1gj4I7nhNk0OqAs9bbK0ftEY9ShDCSZc VRCyp89ML+r90Pnz4qaLdhzgkHUJVgZvyAYcBW85g2i0x6rYq2VXex13qMqdYH+lguJN e4lQ== X-Gm-Message-State: AOAM53011u4Y8B3sah36FywuyT6GNQBbnDzXJHd5eqa+CMutNfGTQtoF 1zGgABDbdYIXhF207uPFvYW8DhafIqU5Rw== X-Google-Smtp-Source: ABdhPJzqiMaBmN3vNxFrIabWhxn0PccdODJ8yXJGQuNfW1GBQC4WTzmNeQ9Ufdfb1aV1Bu+P38TCDw== X-Received: by 2002:a17:90b:230d:: with SMTP id mt13mr1445385pjb.177.1603931973929; Wed, 28 Oct 2020 17:39:33 -0700 (PDT) Received: from localhost ([2620:15c:202:1:f693:9fff:fef4:e70a]) by smtp.gmail.com with ESMTPSA id n64sm754497pfn.134.2020.10.28.17.39.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Oct 2020 17:39:33 -0700 (PDT) Date: Wed, 28 Oct 2020 17:39:31 -0700 From: mka@chromium.org To: Akhil P Oommen Cc: freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dianders@chromium.org, dri-devel@freedesktop.org Subject: Re: [v3,2/3] arm64: dts: qcom: sc7180: Add gpu cooling support Message-ID: <20201029003931.GA1855806@google.com> References: <1603892395-3570-2-git-send-email-akhilpo@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1603892395-3570-2-git-send-email-akhilpo@codeaurora.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Akhil, On Wed, Oct 28, 2020 at 07:09:53PM +0530, Akhil P Oommen wrote: > Add cooling-cells property and the cooling maps for the gpu tzones > to support GPU cooling. > > Signed-off-by: Akhil P Oommen > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 30 +++++++++++++++++++++++------- > 1 file changed, 23 insertions(+), 7 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index d46b383..a7ea029 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -2,7 +2,7 @@ > /* > * SC7180 SoC device tree source > * > - * Copyright (c) 2019, The Linux Foundation. All rights reserved. > + * Copyright (c) 2019-20, The Linux Foundation. All rights reserved. > */ > > #include > @@ -1886,6 +1886,8 @@ > operating-points-v2 = <&gpu_opp_table>; > qcom,gmu = <&gmu>; > > + #cooling-cells = <2>; > + > interconnects = <&gem_noc MASTER_GFX3D &mc_virt SLAVE_EBI1>; > interconnect-names = "gfx-mem"; > > @@ -3825,16 +3827,16 @@ > }; > > gpuss0-thermal { > - polling-delay-passive = <0>; > + polling-delay-passive = <100>; > polling-delay = <0>; > > thermal-sensors = <&tsens0 13>; > > trips { > gpuss0_alert0: trip-point0 { > - temperature = <90000>; > + temperature = <95000>; > hysteresis = <2000>; > - type = "hot"; > + type = "passive"; > }; > > gpuss0_crit: gpuss0_crit { > @@ -3843,19 +3845,26 @@ > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&gpuss0_alert0>; > + cooling-device = <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > gpuss1-thermal { > - polling-delay-passive = <0>; > + polling-delay-passive = <100>; > polling-delay = <0>; > > thermal-sensors = <&tsens0 14>; > > trips { > gpuss1_alert0: trip-point0 { > - temperature = <90000>; > + temperature = <95000>; > hysteresis = <2000>; > - type = "hot"; > + type = "passive"; > }; > > gpuss1_crit: gpuss1_crit { > @@ -3864,6 +3873,13 @@ > type = "critical"; > }; > }; > + > + cooling-maps { > + map0 { > + trip = <&gpuss0_alert0>; Copy & paste error, this should be 'gpuss1_alert0'. > + cooling-device = <&gpu THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; > + }; > + }; > }; > > aoss1-thermal { Other than the C&P error: Reviewed-by: Matthias Kaehlcke