From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A2A0C2D0A3 for ; Thu, 29 Oct 2020 13:14:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 98CDE2075E for ; Thu, 29 Oct 2020 13:14:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="jzVlXEEB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725554AbgJ2NOY (ORCPT ); Thu, 29 Oct 2020 09:14:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53464 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725379AbgJ2NOX (ORCPT ); Thu, 29 Oct 2020 09:14:23 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EAB1C0613D2 for ; Thu, 29 Oct 2020 06:14:23 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id a9so2685131wrg.12 for ; Thu, 29 Oct 2020 06:14:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=9obAPEV8dEZ5dV9K3xznJ6LjVq/00BJ7H8Sv5LddX8E=; b=jzVlXEEB5wHxHJyULvUM42NCvTUEbuK845ME39oBPZNYg0IJBMecqYmh/KSkCCGVV8 PbqwqNcQt3DaD/66WJqHXWtVhEWyY6ImvH/HFiZNsV8tcRxmRwSWJaSIUQXM5wiwBnSU 0vl/CBawp327PcaNJm3L8fn8aWQ+vr4Bw6fgq77vmIUTwBqT+zYZf65RfwcKcdqYLMUS jDFb6rSCB0qTqbLUGvYZ/2W6xTBVF75Bb8YYDnUyr6fa6peEUgaR1W0ZSG5Fupqq1MbE Mq3qPD76Gqll6ZOL2ZQhpfIr2T56I//GMtkm/bhjasLApkuuoIJ/8xvW4bs8iunWSqEu 5F2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=9obAPEV8dEZ5dV9K3xznJ6LjVq/00BJ7H8Sv5LddX8E=; b=Jo02FGhb3UN760zJX0s78yUxm8b0+EaetunQSX5miEz765k84BWGJCUS62P0/65tnn l7IEWH+pctwubLgDAfGw5S3bULcJPT557H87tMV8E9gka4dZ+fYUxmLZjSxCO88uFGuG s9H8S6dTaF/gkXn3fevxBoKveZ97zExadI3+q8Vj6VPn/U6GGW+cXU/UH+VhviVwMooW jufxOeOo4nuBefIp1Y/hXhg/sT4gfbUSbDsA2AaQ0Qp2YeJpG2GZhUBLxkUSRMEv3BBP OVqY9WyZ6OhxXUaSD7vJiFtyENeCFkBvRLHAcpbslRejeI1i0rqu7CQGhNlt72+Nbxl0 56XA== X-Gm-Message-State: AOAM531c61LJZi3h5UDhUR/l7J8f4fRllAB9beNRg/imsEWnvt9RhdOP oJQfRBOWESxtzEeWZMfVc1GmPQ== X-Google-Smtp-Source: ABdhPJxH2GANAc8gVY+RbaHy7HfWpZhTky0wsa4s9YojOReeoSLAMEZ36RhnpquTaKqaa2soG3bIag== X-Received: by 2002:adf:8bce:: with SMTP id w14mr5450324wra.242.1603977261907; Thu, 29 Oct 2020 06:14:21 -0700 (PDT) Received: from dell ([91.110.221.160]) by smtp.gmail.com with ESMTPSA id l11sm4601692wro.89.2020.10.29.06.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 06:14:21 -0700 (PDT) Date: Thu, 29 Oct 2020 13:14:19 +0000 From: Lee Jones To: Shihlun Lin Cc: Mauro Carvalho Chehab , "David S . Miller" , Rob Herring , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Campion Kang , AceLan Kao Subject: Re: [PATCH v3 5/6] mfd: ahc1ec0-hwmon: Add sub-device hwmon for Advantech embedded controller Message-ID: <20201029131419.GA4127@dell> References: <20201029100613.25789-1-shihlun.lin@advantech.com.tw> <20201029100613.25789-5-shihlun.lin@advantech.com.tw> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201029100613.25789-5-shihlun.lin@advantech.com.tw> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 29 Oct 2020, Shihlun Lin wrote: > This is one of sub-device driver for Advantech embedded controller > AHC1EC0. This driver provides sysfs ABI for Advantech related > applications to monitor the system status. > > Signed-off-by: Shihlun Lin > Reported-by: kernel test robot LKP reported that your driver needed upstreaming? I'm confused! > --- > drivers/mfd/Kconfig | 8 + > drivers/mfd/Makefile | 1 + > drivers/mfd/ahc1ec0-hwmon.c | 1514 +++++++++++++++++++++++++++++++++++ This obviously belongs in drivers/hwmon. > 3 files changed, 1523 insertions(+) > create mode 100644 drivers/mfd/ahc1ec0-hwmon.c > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > index 965bcafbe5b2..52ca49b211fc 100644 > --- a/drivers/mfd/Kconfig > +++ b/drivers/mfd/Kconfig > @@ -2175,5 +2175,13 @@ config MFD_AHC1EC0 > provides expose functions for sub-devices to read/write the value > to embedded controller. > > +config MFD_AHC1EC0_HWMON > + tristate "Advantech EC Hareware Monitor Function" > + depends on MFD_AHC1EC0 > + help > + This is sub-device for Advantech embedded controller AHC1EC0. This > + driver provides the sysfs attribues for applications to monitor > + the system status. > + > endmenu > endif > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > index 80a9a2bdc3ba..eb645db817b5 100644 > --- a/drivers/mfd/Makefile > +++ b/drivers/mfd/Makefile > @@ -269,3 +269,4 @@ obj-$(CONFIG_MFD_SIMPLE_MFD_I2C) += simple-mfd-i2c.o > obj-$(CONFIG_MFD_INTEL_M10_BMC) += intel-m10-bmc.o > > obj-$(CONFIG_MFD_AHC1EC0) += ahc1ec0.o > +obj-$(CONFIG_MFD_AHC1EC0_HWMON) += ahc1ec0-hwmon.o > diff --git a/drivers/mfd/ahc1ec0-hwmon.c b/drivers/mfd/ahc1ec0-hwmon.c > new file mode 100644 > index 000000000000..3e493b040b4a > --- /dev/null > +++ b/drivers/mfd/ahc1ec0-hwmon.c > @@ -0,0 +1,1514 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/***************************************************************************** > + * Copyright (c) 2018, Advantech Automation Corp. You can't just lift a whole driver from downstream code and send it to the mailing list as-is. > + * THIS IS AN UNPUBLISHED WORK CONTAINING CONFIDENTIAL AND PROPRIETARY > + * INFORMATION WHICH IS THE PROPERTY OF ADVANTECH AUTOMATION CORP. > + * > + * ANY DISCLOSURE, USE, OR REPRODUCTION, WITHOUT WRITTEN AUTHORIZATION FROM > + * ADVANTECH AUTOMATION CORP., IS STRICTLY PROHIBITED. > + ***************************************************************************** This warning is in contradiction to the licence you are proposing. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog