Re: [PATCH 6/6] doc: dt-binding: cdns,usb3: add wakeup-irq

[Rob Herring <robh@kernel.org>]

On Thu, Oct 22, 2020 at 09:44:11AM +0800, Peter Chen wrote:
> To support low power mode for controller, the driver needs wakeup-irq
> to reflect the signal changing after controller is stopped, and waking
> the controller up accordingly.
> 
> Signed-off-by: Peter Chen <peter.chen@nxp.com>
> ---
>  Documentation/devicetree/bindings/usb/cdns,usb3.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> index ac20b98e9910..0171e64ef95e 100644
> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml
> @@ -30,12 +30,15 @@ properties:
>        - description: OTG/DRD controller interrupt
>        - description: XHCI host controller interrupt
>        - description: Device controller interrupt
> +      - description: interrupt used to wake up core, eg: when usbcmd.rs is
> +      cleared by xhci core, this interrupt is optional.

You need 'minItems: 3' here and below to make this optional. I guess we 
don't have an example for this binding or it would fail.

>  
>    interrupt-names:
>      items:
>        - const: host
>        - const: peripheral
>        - const: otg
> +      - const: wakeup
>  
>    dr_mode:
>      enum: [host, otg, peripheral]
> -- 
> 2.17.1
>