From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2A5BC4741F for ; Fri, 30 Oct 2020 18:45:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9E45220791 for ; Fri, 30 Oct 2020 18:45:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604083522; bh=ltiMzVgrt/A5HFqc01Bz1SI0m+LTL6l05Gi7Z5M6wW8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=zUqdY6+GzK5Jp+xbyP+WXc75Lkvsw2EwhPvedxDPPFfUtjYD+A1Noz8p++lBnc6Du 72ifjhuz8n0HZlpeL66e1RbMTe1Uw3jSwnANvz3Mfm3cUuhiCfIR/dGv2wp3fwBb8m oZnbMw8dWdKDBXkthbUDwypQqqDz3iohaOJ8Sm3s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727255AbgJ3SpW (ORCPT ); Fri, 30 Oct 2020 14:45:22 -0400 Received: from mail-ot1-f68.google.com ([209.85.210.68]:45099 "EHLO mail-ot1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727234AbgJ3SpV (ORCPT ); Fri, 30 Oct 2020 14:45:21 -0400 Received: by mail-ot1-f68.google.com with SMTP id f37so6429559otf.12; Fri, 30 Oct 2020 11:45:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=vkMKJ2eqiQquOQSzTOKFv95/64lgkzU1Z0DoWHjMcuA=; b=A6FgiZXY0sGrATGX7QBElPppe9uMbfAjlNfLRAQS0XDRfmjkJbZTx+v+LyzaFOdRjn lqdbB6qLkmtsQr1//Q9y+LeRcqLxR3VbPRXhvx+DpJOgWh7/taqjvU9mwQaLMZ8/rTkd QTGcnte6O3sHFkhajN11nwU4mqzXg1GWo7pUvUP4HsNgOxOVw4e5ZMWTAdpusqYU2DIh psUTHbVs8r6qJ8RHo1aeciJMKdUIWCyGNeIy7H5PHe7YXpauJ521WgYOFryq1FtoBHTD zBU2v+cmolfFDFDOC/gUqbHgK0Xr+lEcRtlkeIy+7lqRe247OVk8s89iWyOl7poOisu/ Cufw== X-Gm-Message-State: AOAM531F0HLMq7gnp13DZ+4rjydYy9Sr+fhcEPmb3uEZp5M4im+2ihip 1YnnsbxNu4t0NJs/AJJY9g== X-Google-Smtp-Source: ABdhPJz1noWcHkG0acilS14npra1FTJs7FrC7ortYfxhp6d4ZfvWMrm3RWg2qWwzEfFkMkGYTGwg2g== X-Received: by 2002:a05:6830:1db6:: with SMTP id z22mr2597009oti.20.1604083520849; Fri, 30 Oct 2020 11:45:20 -0700 (PDT) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id 186sm1556392ooe.20.2020.10.30.11.45.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Oct 2020 11:45:16 -0700 (PDT) Received: (nullmailer pid 4129088 invoked by uid 1000); Fri, 30 Oct 2020 18:45:15 -0000 Date: Fri, 30 Oct 2020 13:45:15 -0500 From: Rob Herring To: =?utf-8?B?5ZGo55Cw5p2wIChaaG91IFlhbmppZSk=?= Cc: dongsheng.qiu@ingenic.com, rick.tyliu@ingenic.com, robh+dt@kernel.org, sernia.zhou@foxmail.com, aric.pzqi@ingenic.com, yanfei.li@ingenic.com, zhenwenjin@gmail.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, daniel.lezcano@linaro.org Subject: Re: [PATCH v3 1/1] dt-bindings: timer: Add new OST support for the upcoming new driver. Message-ID: <20201030184515.GA4129054@bogus> References: <20201026155842.10196-1-zhouyanjie@wanyeetech.com> <20201026155842.10196-2-zhouyanjie@wanyeetech.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201026155842.10196-2-zhouyanjie@wanyeetech.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 26 Oct 2020 23:58:42 +0800, 周琰杰 (Zhou Yanjie) wrote: > The new OST has one global timer and two or four percpu timers, so there > will be three combinations in the upcoming new OST driver: the original > GLOBAL_TIMER + PERCPU_TIMER, the new GLOBAL_TIMER + PERCPU_TIMER0/1 and > GLOBAL_TIMER + PERCPU_TIMER0/1/2/3, For this, add the macro definition > about OST_CLK_PERCPU_TIMER0/1/2/3. And in order to ensure that all the > combinations work normally, the original ABI values of OST_CLK_PERCPU_TIMER > and OST_CLK_GLOBAL_TIMER need to be exchanged to ensure that in any > combinations, the clock can be registered (by calling clk_hw_register()) > from index 0. > > Before this patch, OST_CLK_PERCPU_TIMER and OST_CLK_GLOBAL_TIMER are only > used in two places, one is when using "assigned-clocks" to configure the > clocks in the DTS file; the other is when registering the clocks in the > sysost driver. When the values of these two ABIs are exchanged, the ABI > value used by sysost driver when registering the clock, and the ABI value > used by DTS when configuring the clock using "assigned-clocks" will also > change accordingly. Therefore, there is no situation that causes the wrong > clock to the configured. Therefore, exchanging ABI values will not cause > errors in the existing codes when registering and configuring the clocks. > > Currently, in the mainline, only X1000 and X1830 are using sysost driver, > and the upcoming X2000 will also use sysost driver. This patch has been > tested on all three SoCs and all works fine. > > Tested-by: 周正 (Zhou Zheng) > Signed-off-by: 周琰杰 (Zhou Yanjie) > --- > > Notes: > v1->v2: > Rewrite the commit message so that each line is less than 80 characters. > > v2->v3: > Add the description of why the exchange of ABI values will not affect > the existing driver into the commit message. > > include/dt-bindings/clock/ingenic,sysost.h | 10 +++++++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring