* [PATCH leds 4/5] dt-bindings: leds: leds-class-multicolor: use LED_COLOR_ID_RGB for now [not found] <20201030023906.24259-1-kabel@kernel.org> @ 2020-10-30 2:39 ` Marek Behún 2020-10-30 13:08 ` Dan Murphy 0 siblings, 1 reply; 5+ messages in thread From: Marek Behún @ 2020-10-30 2:39 UTC (permalink / raw) To: linux-leds Cc: Dan Murphy, Pavel Machek, Marek Behún, devicetree, robh+dt Commit 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") disallows LED_COLOR_ID_MULTI for now, and instead LED_COLOR_ID_RGB should be used. Fix this is leds-class-multicolor binding. After we have some usecases for non-RGB multicolor LEDs, this can be changed. Signed-off-by: Marek Behún <kabel@kernel.org> Fixes: 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") Cc: devicetree@vger.kernel.org Cc: robh+dt@kernel.org --- .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 4 ++-- .../devicetree/bindings/leds/leds-class-multicolor.yaml | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml index fe7fa25877fd..2015db9b7618 100644 --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml @@ -73,14 +73,14 @@ examples: * LEDs. */ reg = <0>; - color = <LED_COLOR_ID_MULTI>; + color = <LED_COLOR_ID_RGB>; function = LED_FUNCTION_POWER; linux,default-trigger = "heartbeat"; }; multi-led@a { reg = <0xa>; - color = <LED_COLOR_ID_MULTI>; + color = <LED_COLOR_ID_RGB>; function = LED_FUNCTION_INDICATOR; function-enumerator = <1>; }; diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml index b1a53f054b89..9faa3609a6bb 100644 --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml @@ -25,10 +25,10 @@ patternProperties: description: Represents the LEDs that are to be grouped. properties: color: - const: 8 # LED_COLOR_ID_MULTI + const: 9 # LED_COLOR_ID_RGB description: | For multicolor LED support this property should be defined as - LED_COLOR_ID_MULTI which can be found in include/linux/leds/common.h. + LED_COLOR_ID_RGB which can be found in include/linux/leds/common.h. $ref: "common.yaml#" -- 2.26.2 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH leds 4/5] dt-bindings: leds: leds-class-multicolor: use LED_COLOR_ID_RGB for now 2020-10-30 2:39 ` [PATCH leds 4/5] dt-bindings: leds: leds-class-multicolor: use LED_COLOR_ID_RGB for now Marek Behún @ 2020-10-30 13:08 ` Dan Murphy 2020-10-30 21:46 ` Marek Behún 2020-11-04 21:55 ` Rob Herring 0 siblings, 2 replies; 5+ messages in thread From: Dan Murphy @ 2020-10-30 13:08 UTC (permalink / raw) To: Marek Behún, linux-leds; +Cc: Pavel Machek, devicetree, robh+dt Marek On 10/29/20 9:39 PM, Marek Behún wrote: > Commit 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") > disallows LED_COLOR_ID_MULTI for now, and instead LED_COLOR_ID_RGB > should be used. Fix this is leds-class-multicolor binding. > > After we have some usecases for non-RGB multicolor LEDs, this can be > changed. > > Signed-off-by: Marek Behún <kabel@kernel.org> > Fixes: 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") > Cc: devicetree@vger.kernel.org > Cc: robh+dt@kernel.org > --- > .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 4 ++-- > .../devicetree/bindings/leds/leds-class-multicolor.yaml | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > index fe7fa25877fd..2015db9b7618 100644 > --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > @@ -73,14 +73,14 @@ examples: > * LEDs. > */ > reg = <0>; > - color = <LED_COLOR_ID_MULTI>; > + color = <LED_COLOR_ID_RGB>; > function = LED_FUNCTION_POWER; > linux,default-trigger = "heartbeat"; > }; > > multi-led@a { > reg = <0xa>; > - color = <LED_COLOR_ID_MULTI>; > + color = <LED_COLOR_ID_RGB>; > function = LED_FUNCTION_INDICATOR; > function-enumerator = <1>; > }; > diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > index b1a53f054b89..9faa3609a6bb 100644 > --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml Why are you resubmitting the multicolor.yaml? https://lore.kernel.org/patchwork/patch/1320863/ This is waiting on DT review. Dan ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH leds 4/5] dt-bindings: leds: leds-class-multicolor: use LED_COLOR_ID_RGB for now 2020-10-30 13:08 ` Dan Murphy @ 2020-10-30 21:46 ` Marek Behún 2020-11-04 21:55 ` Rob Herring 1 sibling, 0 replies; 5+ messages in thread From: Marek Behún @ 2020-10-30 21:46 UTC (permalink / raw) To: Dan Murphy; +Cc: linux-leds, Pavel Machek, devicetree, robh+dt On Fri, 30 Oct 2020 08:08:01 -0500 Dan Murphy <dmurphy@ti.com> wrote: > Why are you resubmitting the multicolor.yaml? > > https://lore.kernel.org/patchwork/patch/1320863/ > > This is waiting on DT review. > > Dan > I must have overlooked that patch, sorry. ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH leds 4/5] dt-bindings: leds: leds-class-multicolor: use LED_COLOR_ID_RGB for now 2020-10-30 13:08 ` Dan Murphy 2020-10-30 21:46 ` Marek Behún @ 2020-11-04 21:55 ` Rob Herring 2020-11-04 21:58 ` Dan Murphy 1 sibling, 1 reply; 5+ messages in thread From: Rob Herring @ 2020-11-04 21:55 UTC (permalink / raw) To: Dan Murphy; +Cc: Marek Behún, linux-leds, Pavel Machek, devicetree On Fri, Oct 30, 2020 at 08:08:01AM -0500, Dan Murphy wrote: > Marek > > On 10/29/20 9:39 PM, Marek Behún wrote: > > Commit 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") > > disallows LED_COLOR_ID_MULTI for now, and instead LED_COLOR_ID_RGB > > should be used. Fix this is leds-class-multicolor binding. > > > > After we have some usecases for non-RGB multicolor LEDs, this can be > > changed. > > > > Signed-off-by: Marek Behún <kabel@kernel.org> > > Fixes: 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") > > Cc: devicetree@vger.kernel.org > > Cc: robh+dt@kernel.org > > --- > > .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 4 ++-- > > .../devicetree/bindings/leds/leds-class-multicolor.yaml | 4 ++-- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > > index fe7fa25877fd..2015db9b7618 100644 > > --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > > +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml > > @@ -73,14 +73,14 @@ examples: > > * LEDs. > > */ > > reg = <0>; > > - color = <LED_COLOR_ID_MULTI>; > > + color = <LED_COLOR_ID_RGB>; > > function = LED_FUNCTION_POWER; > > linux,default-trigger = "heartbeat"; > > }; > > multi-led@a { > > reg = <0xa>; > > - color = <LED_COLOR_ID_MULTI>; > > + color = <LED_COLOR_ID_RGB>; > > function = LED_FUNCTION_INDICATOR; > > function-enumerator = <1>; > > }; > > diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > > index b1a53f054b89..9faa3609a6bb 100644 > > --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > > +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml > > Why are you resubmitting the multicolor.yaml? > > https://lore.kernel.org/patchwork/patch/1320863/ > > This is waiting on DT review. I'm expecting another version as you commented on it. Rob ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH leds 4/5] dt-bindings: leds: leds-class-multicolor: use LED_COLOR_ID_RGB for now 2020-11-04 21:55 ` Rob Herring @ 2020-11-04 21:58 ` Dan Murphy 0 siblings, 0 replies; 5+ messages in thread From: Dan Murphy @ 2020-11-04 21:58 UTC (permalink / raw) To: Rob Herring; +Cc: Marek Behún, linux-leds, Pavel Machek, devicetree Rob On 11/4/20 3:55 PM, Rob Herring wrote: > On Fri, Oct 30, 2020 at 08:08:01AM -0500, Dan Murphy wrote: >> Marek >> >> On 10/29/20 9:39 PM, Marek Behún wrote: >>> Commit 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") >>> disallows LED_COLOR_ID_MULTI for now, and instead LED_COLOR_ID_RGB >>> should be used. Fix this is leds-class-multicolor binding. >>> >>> After we have some usecases for non-RGB multicolor LEDs, this can be >>> changed. >>> >>> Signed-off-by: Marek Behún <kabel@kernel.org> >>> Fixes: 77dce3a22e89 ("leds: disallow /sys/class/leds/*:multi:* for now") >>> Cc: devicetree@vger.kernel.org >>> Cc: robh+dt@kernel.org >>> --- >>> .../devicetree/bindings/leds/cznic,turris-omnia-leds.yaml | 4 ++-- >>> .../devicetree/bindings/leds/leds-class-multicolor.yaml | 4 ++-- >>> 2 files changed, 4 insertions(+), 4 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml >>> index fe7fa25877fd..2015db9b7618 100644 >>> --- a/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml >>> +++ b/Documentation/devicetree/bindings/leds/cznic,turris-omnia-leds.yaml >>> @@ -73,14 +73,14 @@ examples: >>> * LEDs. >>> */ >>> reg = <0>; >>> - color = <LED_COLOR_ID_MULTI>; >>> + color = <LED_COLOR_ID_RGB>; >>> function = LED_FUNCTION_POWER; >>> linux,default-trigger = "heartbeat"; >>> }; >>> multi-led@a { >>> reg = <0xa>; >>> - color = <LED_COLOR_ID_MULTI>; >>> + color = <LED_COLOR_ID_RGB>; >>> function = LED_FUNCTION_INDICATOR; >>> function-enumerator = <1>; >>> }; >>> diff --git a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml >>> index b1a53f054b89..9faa3609a6bb 100644 >>> --- a/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml >>> +++ b/Documentation/devicetree/bindings/leds/leds-class-multicolor.yaml >> Why are you resubmitting the multicolor.yaml? >> >> https://lore.kernel.org/patchwork/patch/1320863/ >> >> This is waiting on DT review. > I'm expecting another version as you commented on it. Yes you applied v2 https://www.spinics.net/lists/devicetree/msg384974.html Dan > Rob ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-11-04 21:59 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201030023906.24259-1-kabel@kernel.org>
2020-10-30 2:39 ` [PATCH leds 4/5] dt-bindings: leds: leds-class-multicolor: use LED_COLOR_ID_RGB for now Marek Behún
2020-10-30 13:08 ` Dan Murphy
2020-10-30 21:46 ` Marek Behún
2020-11-04 21:55 ` Rob Herring
2020-11-04 21:58 ` Dan Murphy
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).