From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5ED77C00A89 for ; Fri, 30 Oct 2020 23:37:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0997822245 for ; Fri, 30 Oct 2020 23:37:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725806AbgJ3Xho (ORCPT ); Fri, 30 Oct 2020 19:37:44 -0400 Received: from alexa-out-sd-02.qualcomm.com ([199.106.114.39]:28683 "EHLO alexa-out-sd-02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725446AbgJ3Xho (ORCPT ); Fri, 30 Oct 2020 19:37:44 -0400 Received: from unknown (HELO ironmsg-SD-alpha.qualcomm.com) ([10.53.140.30]) by alexa-out-sd-02.qualcomm.com with ESMTP; 30 Oct 2020 16:37:43 -0700 X-QCInternal: smtphost Received: from gurus-linux.qualcomm.com ([10.46.162.81]) by ironmsg-SD-alpha.qualcomm.com with ESMTP; 30 Oct 2020 16:37:43 -0700 Received: by gurus-linux.qualcomm.com (Postfix, from userid 383780) id C20C5199F; Fri, 30 Oct 2020 16:37:42 -0700 (PDT) Date: Fri, 30 Oct 2020 16:37:42 -0700 From: Guru Das Srinagesh To: Rob Herring Cc: Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, Subbaraman Narayanamurthy , David Collins , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd , Anirudh Ghayal Subject: Re: [PATCH v4 2/3] bindings: pm8941-misc: Add support for VBUS detection Message-ID: <20201030233742.GA29492@codeaurora.org> References: <6c6bd3601ec8f4c68f581452fca3ef96f2ae94f9.1603869292.git.gurus@codeaurora.org> <20201030133612.GB3721479@bogus> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201030133612.GB3721479@bogus> User-Agent: Mutt/1.5.24 (2015-08-30) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, Oct 30, 2020 at 08:36:12AM -0500, Rob Herring wrote: > On Wed, Oct 28, 2020 at 12:18:53AM -0700, Guru Das Srinagesh wrote: > > Add compatible string that adds support for reporting VBUS detection > > status that can be detected via a dedicated PMIC pin. > > > > Signed-off-by: Anirudh Ghayal > > Signed-off-by: Guru Das Srinagesh > > --- > > Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml | 7 ++++++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml b/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml > > index e8eea83..15e3749 100644 > > --- a/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml > > +++ b/Documentation/devicetree/bindings/extcon/qcom,pm8941-misc.yaml > > @@ -15,18 +15,23 @@ description: | > > > > properties: > > compatible: > > + minItems: 1 > > items: > > - const: qcom,pm8941-misc > > + - const: qcom,pmd-vbus-det > > Do you really need another compatible here? Just detect this by having a > 2nd interrupt. Agreed; will drop this bit in the next patchset. > > > > > reg: > > maxItems: 1 > > > > interrupts: > > - maxItems: 1 > > + minItems: 1 > > + maxItems: 2 > > > > interrupt-names: > > + minItems: 1 > > items: > > - const: usb_id > > + - const: usb_vbus > > > > required: > > - compatible > > -- > > The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, > > a Linux Foundation Collaborative Project > >