devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Thierry Reding <thierry.reding@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Christophe Branchereau <cbranchereau@gmail.com>,
	od@zcrc.me, dri-devel@lists.freedesktop.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3] drm/panel: ABT Y030XX067A panel support
Date: Sun, 1 Nov 2020 13:26:11 +0100	[thread overview]
Message-ID: <20201101122611.GA1269759@ravnborg.org> (raw)
In-Reply-To: <20201101093150.8071-1-paul@crapouillou.net>

Hi Paul.

On Sun, Nov 01, 2020 at 09:31:46AM +0000, Paul Cercueil wrote:
> Hi,
> 
> This patchset is for adding support for the Asia Better Technology (aka.
> ABT) Y030XX067A 3.0" 320x480 24-bit LCD IPS panel.
> 
> While being 320x480 it is actually 4:3 with non-square pixels, and
> requires a specific bus format, as the pixel ordering changes each line
> (RGB on odd lines, GRB on even lines).
> 
> Patch #1 adds the abt,* vendor prefix.
> Patch #2 adds the abt,y030xx067a panel binding documentation.
> Patch #3 adds the MEDIA_BUS_FMT_RGB888_3X8_DELTA media bus format.
> Patch #4 adds the driver itself.

Full series looks good.

I asked google - but no hits for "Asia Better Technology". But I blame
that the company has no public page - in english at least.
Also the part with a DELTA media bus format looks correct, but not
something I know much off.

The driver itself utilises regmap_multi_reg_write() - very nice!

Full series is:
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>

I assume you will apply yourself - but please wait a few days after it
have hit dri-devel to let others have the possibility to give feedback.

	Sam

  parent reply	other threads:[~2020-11-01 12:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-01  9:31 [PATCH 0/3] drm/panel: ABT Y030XX067A panel support Paul Cercueil
2020-11-01  9:31 ` [PATCH 1/4] dt-bindings: vendor-prefixes: Add abt vendor prefix Paul Cercueil
2020-11-04 22:32   ` Rob Herring
2020-11-01  9:31 ` [PATCH 2/4] dt-bindings: display: Add ABT Y030XX067A panel bindings Paul Cercueil
2020-11-01 12:29   ` Sam Ravnborg
2020-11-02 10:19     ` Paul Cercueil
2020-11-30 14:32       ` Rob Herring
2020-11-30 19:39         ` Paul Cercueil
2020-11-30 20:18           ` Rob Herring
2020-11-30 21:48             ` Paul Cercueil
2020-12-05 19:55               ` Sam Ravnborg
2020-11-01  9:31 ` [PATCH 3/4] media: uapi: Add MEDIA_BUS_FMT_RGB888_3X8_DELTA media bus format Paul Cercueil
2020-11-01  9:31 ` [PATCH 4/4] drm/panel: Add ABT Y030XX067A 3.0" 320x480 panel Paul Cercueil
2020-11-01 12:26 ` Sam Ravnborg [this message]
2020-12-17  0:59 ` [PATCH] dt-bindings/display: abt,y030xx067a: Fix binding Paul Cercueil
2020-12-17  6:03   ` Sam Ravnborg
2020-12-18 21:17   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201101122611.GA1269759@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=cbranchereau@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=od@zcrc.me \
    --cc=paul@crapouillou.net \
    --cc=robh+dt@kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).