From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1EC0FC2D0A3 for ; Sun, 1 Nov 2020 12:26:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BB9A822253 for ; Sun, 1 Nov 2020 12:26:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726499AbgKAM0R (ORCPT ); Sun, 1 Nov 2020 07:26:17 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:48618 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726474AbgKAM0R (ORCPT ); Sun, 1 Nov 2020 07:26:17 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 85B9220022; Sun, 1 Nov 2020 13:26:13 +0100 (CET) Date: Sun, 1 Nov 2020 13:26:11 +0100 From: Sam Ravnborg To: Paul Cercueil Cc: Thierry Reding , Rob Herring , Christophe Branchereau , od@zcrc.me, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] drm/panel: ABT Y030XX067A panel support Message-ID: <20201101122611.GA1269759@ravnborg.org> References: <20201101093150.8071-1-paul@crapouillou.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201101093150.8071-1-paul@crapouillou.net> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=7gkXJVJtAAAA:8 a=9Q3-Gd2UY0mbpF3q5_8A:9 a=CjuIK1q_8ugA:10 a=E9Po1WZjFZOl8hwRPBS3:22 a=pHzHmUro8NiASowvMSCR:22 a=nt3jZW36AmriUCFCBwmW:22 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Paul. On Sun, Nov 01, 2020 at 09:31:46AM +0000, Paul Cercueil wrote: > Hi, > > This patchset is for adding support for the Asia Better Technology (aka. > ABT) Y030XX067A 3.0" 320x480 24-bit LCD IPS panel. > > While being 320x480 it is actually 4:3 with non-square pixels, and > requires a specific bus format, as the pixel ordering changes each line > (RGB on odd lines, GRB on even lines). > > Patch #1 adds the abt,* vendor prefix. > Patch #2 adds the abt,y030xx067a panel binding documentation. > Patch #3 adds the MEDIA_BUS_FMT_RGB888_3X8_DELTA media bus format. > Patch #4 adds the driver itself. Full series looks good. I asked google - but no hits for "Asia Better Technology". But I blame that the company has no public page - in english at least. Also the part with a DELTA media bus format looks correct, but not something I know much off. The driver itself utilises regmap_multi_reg_write() - very nice! Full series is: Reviewed-by: Sam Ravnborg I assume you will apply yourself - but please wait a few days after it have hit dri-devel to let others have the possibility to give feedback. Sam