From: kernel test robot <lkp@intel.com>
To: alexandru.tachici@analog.com, linux-hwmon@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Cc: kbuild-all@lists.01.org, robh+dt@kernel.org, linux@roeck-us.net,
Alexandru Tachici <alexandru.tachici@analog.com>
Subject: Re: [PATCH 2/3] hwmon: ltc2992: Add support for GPIOs.
Date: Mon, 2 Nov 2020 02:32:29 +0800 [thread overview]
Message-ID: <202011020235.MwAE3ayy-lkp@intel.com> (raw)
In-Reply-To: <20201029094911.79173-3-alexandru.tachici@analog.com>
[-- Attachment #1: Type: text/plain, Size: 2741 bytes --]
Hi,
I love your patch! Perhaps something to improve:
[auto build test WARNING on hwmon/hwmon-next]
[also build test WARNING on linus/master linux/master v5.10-rc1 next-20201030]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/alexandru-tachici-analog-com/hwmon-ltc2992-Add-support/20201029-174720
base: https://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git hwmon-next
config: c6x-randconfig-r011-20201101 (attached as .config)
compiler: c6x-elf-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/0day-ci/linux/commit/f74af3cc59b7d9de6545502e7d01df6e01f96773
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review alexandru-tachici-analog-com/hwmon-ltc2992-Add-support/20201029-174720
git checkout f74af3cc59b7d9de6545502e7d01df6e01f96773
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=c6x
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/hwmon/ltc2992.c:276:6: warning: no previous prototype for 'ltc2992_gpio_set_multiple' [-Wmissing-prototypes]
276 | void ltc2992_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask, unsigned long *bits)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
vim +/ltc2992_gpio_set_multiple +276 drivers/hwmon/ltc2992.c
275
> 276 void ltc2992_gpio_set_multiple(struct gpio_chip *chip, unsigned long *mask, unsigned long *bits)
277 {
278 struct ltc2992_state *st = gpiochip_get_data(chip);
279 unsigned long gpio_ctrl_io = 0;
280 unsigned long gpio_ctrl = 0;
281 unsigned int gpio_nr;
282
283 for_each_set_bit(gpio_nr, mask, LTC2992_GPIO_NR) {
284 if (gpio_nr < 3)
285 assign_bit(ltc2992_gpio_addr_map[gpio_nr].ctrl_bit, &gpio_ctrl_io, true);
286
287 if (gpio_nr == 3)
288 assign_bit(ltc2992_gpio_addr_map[gpio_nr].ctrl_bit, &gpio_ctrl, true);
289 }
290
291 mutex_lock(&st->gpio_mutex);
292 ltc2992_write_reg(st, LTC2992_GPIO_IO_CTRL, 1, gpio_ctrl_io);
293 ltc2992_write_reg(st, LTC2992_GPIO_CTRL, 1, gpio_ctrl);
294 mutex_unlock(&st->gpio_mutex);
295 }
296
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 23276 bytes --]
next prev parent reply other threads:[~2020-11-01 18:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-29 9:49 [PATCH 0/3] hwmon: ltc2992: Add support alexandru.tachici
2020-10-29 9:49 ` [PATCH 1/3] " alexandru.tachici
2020-11-04 5:54 ` Guenter Roeck
2020-10-29 9:49 ` [PATCH 2/3] hwmon: ltc2992: Add support for GPIOs alexandru.tachici
2020-10-30 8:15 ` kernel test robot
2020-11-01 18:32 ` kernel test robot [this message]
2020-11-08 17:33 ` Guenter Roeck
2020-10-29 9:49 ` [PATCH 3/3] dt-binding: hwmon: Add documentation for ltc2992 alexandru.tachici
2020-10-29 15:36 ` Rob Herring
2020-10-29 15:37 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202011020235.MwAE3ayy-lkp@intel.com \
--to=lkp@intel.com \
--cc=alexandru.tachici@analog.com \
--cc=devicetree@vger.kernel.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).