From: Miquel Raynal <miquel.raynal@bootlin.com>
To: 赵仪峰 <yifeng.zhao@rock-chips.com>
Cc: "Johan Jonker" <jbx6244@gmail.com>, richard <richard@nod.at>,
vigneshr <vigneshr@ti.com>, robh+dt <robh+dt@kernel.org>,
devicetree <devicetree@vger.kernel.org>,
HeikoStübner <heiko@sntech.de>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-rockchip <linux-rockchip@lists.infradead.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others
Date: Mon, 2 Nov 2020 08:32:58 +0100 [thread overview]
Message-ID: <20201102083258.3a748c44@xps13> (raw)
In-Reply-To: <20201102114503679684135@rock-chips.com>
Hello,
赵仪峰 <yifeng.zhao@rock-chips.com> wrote on Mon, 2 Nov 2020 11:46:04
+0800:
> Hi Johan,
>
> void nand_deselect_target(struct nand_chip *chip)
> {
> if (chip->legacy.select_chip)
> chip->legacy.select_chip(chip, -1);
>
> chip->cur_cs = -1;
> }
>
> I need add the code below and it work.
>
> chip->legacy.select_chip = rk_nfc_select_chip;
>
> But I found almost all nandc drivers do not add this code. Is there any other way to implement it？
Indeed, we don't accept new code we legacy bindings.
I don't understand what extra consumption you are trying to avoid,
because if it is the NAND device itself that is able to save power when
it gets unselected, it's really none of you controller's business.
Perhaps it's the time to focus on the controller support and tune the
code base later in a bid to reduce consumption.
Thanks,
Miquèl
next prev parent reply other threads:[~2020-11-02 7:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20201028095326.15562-1-yifeng.zhao@rock-chips.com>
[not found] ` <20201028095326.15562-3-yifeng.zhao@rock-chips.com>
2020-10-28 10:48 ` [PATCH v13 2/8] mtd: rawnand: rockchip: NFC drivers for RK3308, RK2928 and others Miquel Raynal
2020-10-30 10:12 ` 赵仪峰
2020-10-30 10:26 ` Miquel Raynal
2020-10-31 11:58 ` Johan Jonker
2020-10-31 13:45 ` Johan Jonker
2020-11-02 3:46 ` 赵仪峰
2020-11-02 7:32 ` Miquel Raynal [this message]
2020-11-02 8:14 ` 赵仪峰
2020-11-02 8:20 ` Miquel Raynal
[not found] ` <e02e13a0-769d-6b73-c87e-5b7d75fd4254@rock-chips.com>
2020-11-02 12:57 ` Johan Jonker
2020-11-02 13:07 ` Miquel Raynal
2020-11-02 13:11 ` Johan Jonker
2020-11-02 16:31 ` Johan Jonker
2020-11-02 17:00 ` Miquel Raynal
2020-11-02 17:11 ` Johan Jonker
2020-11-04 7:30 ` 赵仪峰
2020-11-04 7:34 ` 赵仪峰
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201102083258.3a748c44@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jbx6244@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=yifeng.zhao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).