From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC0B2C00A89 for ; Mon, 2 Nov 2020 10:14:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 73742223AB for ; Mon, 2 Nov 2020 10:14:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="trYgFDTQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728445AbgKBKOZ (ORCPT ); Mon, 2 Nov 2020 05:14:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37086 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728156AbgKBKOY (ORCPT ); Mon, 2 Nov 2020 05:14:24 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F7FCC0617A6 for ; Mon, 2 Nov 2020 02:14:23 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id a9so13843015wrg.12 for ; Mon, 02 Nov 2020 02:14:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=t1K0NwlSDb4++OllbH1h9aaEG4tdnBfR2XD4G2HdxPs=; b=trYgFDTQak6WcxQiw32NmN3mw+gKSInrqOFdT+jMG2NIWp7hcgj5oHXFeLs/YHoufj 7gCVSIMIX5hD0IgibN2wTKv/oM2o+7NhjEu5m6T1ZmNVgD6BLb7V627ux56Ig7Fv6byS Pu1bYCMTBr9uiGDk0VHCUMGuBLlp/bOc6dOHWpL8PyWeHQ39i2cmZTCD6+nwKGfzi+Q7 oELd5uHpk5RmRQG1t/yrvv6J7rzq5WSaM68tDqaew6t6YAmMRQlo8QMba8R45jDQzmGC DrzYRwUsnZhuWzOaorE0zYY5IdiHf8XTYLR1T8yWyur5NDxwMzXXHVY6n2TOlZR0dYjW AXZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=t1K0NwlSDb4++OllbH1h9aaEG4tdnBfR2XD4G2HdxPs=; b=mBkeQYl61LOXq4F+wf66iiCDho8hqvkCp0T3Pt3AVOBfHRrTTYgkYAo89mUvG3ga7K STrmKbBIM1wZRwHyQ5syDVeAVw5/jNRyWAtlGsGLC7+u3K+ByF/UoknqvHd7sFzaHqgk 4mKF+ahqgKZ4bjwZClViHEVy1pJnW8u8oi04E4nv4sy9w3GzmL9eoRtTnRXzIizU9aAt 3giYCofWuH1zWENoyIjrYwdYLvgVSjeEsZFSLaTsfNIHV9i1Nf79zQ7r0+LfP1NY1EQK hMcxG0CJJZBJBG2RvxYm/2uMpoX93SuhfrPWhbn+JA4KsMQkNo5Dpi3wcJuFVH+AKWFz 6pOQ== X-Gm-Message-State: AOAM533zpdire9svbHYBxsef1FjgNdVtF+eLij2FZ3+72CEtG65g94cQ eImxpNqhweo+yZEynLA9FUtiqA== X-Google-Smtp-Source: ABdhPJxWAwlYcJo5f5G4ksFvQH+/FvBMet+9BoaiMgahkLH5FFiF4dE/eVH9LV70XI4WzVU6vDgxow== X-Received: by 2002:adf:e5c1:: with SMTP id a1mr13889466wrn.12.1604312061862; Mon, 02 Nov 2020 02:14:21 -0800 (PST) Received: from dell ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id h4sm21487621wrp.52.2020.11.02.02.14.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 02:14:21 -0800 (PST) Date: Mon, 2 Nov 2020 10:14:19 +0000 From: Lee Jones To: "Shihlun.Lin" Cc: Mauro Carvalho Chehab , "David S . Miller" , Rob Herring , "linux-kernel@vger.kernel.org" , "devicetree@vger.kernel.org" , "Campion.Kang" , AceLan Kao Subject: Re: [PATCH v3 5/6] mfd: ahc1ec0-hwmon: Add sub-device hwmon for Advantech embedded controller Message-ID: <20201102101419.GI4127@dell> References: <20201029100613.25789-1-shihlun.lin@advantech.com.tw> <20201029100613.25789-5-shihlun.lin@advantech.com.tw> <20201029131419.GA4127@dell> <1e5710f4214b4e8b84f761a260d9dd5b@taipei09.ADVANTECH.CORP> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1e5710f4214b4e8b84f761a260d9dd5b@taipei09.ADVANTECH.CORP> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 02 Nov 2020, Shihlun.Lin wrote: > Hi Lee, > > Thank you for your time for checking my submission. > > > On Thu, 29 Oct 2020, Shihlun Lin wrote: > > > > > This is one of sub-device driver for Advantech embedded controller > > > AHC1EC0. This driver provides sysfs ABI for Advantech related > > > applications to monitor the system status. > > > > > > Signed-off-by: Shihlun Lin > > > Reported-by: kernel test robot > > > > LKP reported that your driver needed upstreaming? > > > > I'm confused! > > > > When I submitted the driver first time, LKP reported some warning to me and ask me to add the tag. > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > Link: https://www.spinics.net/lists/kernel/msg3698194.html That would only be for the fix. Having a test robot report a missing driver seems odd. > > > --- > > > drivers/mfd/Kconfig | 8 + > > > drivers/mfd/Makefile | 1 + > > > drivers/mfd/ahc1ec0-hwmon.c | 1514 > > +++++++++++++++++++++++++++++++++++ > > > > This obviously belongs in drivers/hwmon. > > > > Thank you so much, I will do it. > > > > 3 files changed, 1523 insertions(+) > > > create mode 100644 drivers/mfd/ahc1ec0-hwmon.c > > > > > > diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig > > > index 965bcafbe5b2..52ca49b211fc 100644 > > > --- a/drivers/mfd/Kconfig > > > +++ b/drivers/mfd/Kconfig > > > @@ -2175,5 +2175,13 @@ config MFD_AHC1EC0 > > > provides expose functions for sub-devices to read/write the value > > > to embedded controller. > > > > > > +config MFD_AHC1EC0_HWMON > > > + tristate "Advantech EC Hareware Monitor Function" > > > + depends on MFD_AHC1EC0 > > > + help > > > + This is sub-device for Advantech embedded controller AHC1EC0. This > > > + driver provides the sysfs attribues for applications to monitor > > > + the system status. > > > + > > > endmenu > > > endif > > > diff --git a/drivers/mfd/Makefile b/drivers/mfd/Makefile > > > index 80a9a2bdc3ba..eb645db817b5 100644 > > > --- a/drivers/mfd/Makefile > > > +++ b/drivers/mfd/Makefile > > > @@ -269,3 +269,4 @@ obj-$(CONFIG_MFD_SIMPLE_MFD_I2C) += > > simple-mfd-i2c.o > > > obj-$(CONFIG_MFD_INTEL_M10_BMC) += intel-m10-bmc.o > > > > > > obj-$(CONFIG_MFD_AHC1EC0) += ahc1ec0.o > > > +obj-$(CONFIG_MFD_AHC1EC0_HWMON) += ahc1ec0-hwmon.o > > > diff --git a/drivers/mfd/ahc1ec0-hwmon.c b/drivers/mfd/ahc1ec0-hwmon.c > > > new file mode 100644 > > > index 000000000000..3e493b040b4a > > > --- /dev/null > > > +++ b/drivers/mfd/ahc1ec0-hwmon.c > > > @@ -0,0 +1,1514 @@ > > > +// SPDX-License-Identifier: GPL-2.0-only > > > > > +/************************************************************** > > *************** > > > + * Copyright (c) 2018, Advantech Automation Corp. > > > > You can't just lift a whole driver from downstream code and send it to > > the mailing list as-is. > > > > Could you give me more advice about how to submit the whole driver? > Is there any website to guide me? There is lots of documentation on how to upstream code/drivers in the /Documentation folder. Start here: https://www.kernel.org/doc/html/latest/process/submitting-patches.html Note, this online document, along with all of the others you will required are actually contained in /Documentation, in the kernel source tree. > Thank you so much. > > > > + * THIS IS AN UNPUBLISHED WORK CONTAINING CONFIDENTIAL AND > > PROPRIETARY > > > + * INFORMATION WHICH IS THE PROPERTY OF ADVANTECH AUTOMATION > > CORP. > > > + * > > > + * ANY DISCLOSURE, USE, OR REPRODUCTION, WITHOUT WRITTEN > > AUTHORIZATION FROM > > > + * ADVANTECH AUTOMATION CORP., IS STRICTLY PROHIBITED. > > > + > > **************************************************************** > > ************* > > > > This warning is in contradiction to the licence you are proposing. > > Thank you so much, I will remove it. You'd better seek proper permission from your legal department before doing so. Subverting licence agreements can land you in heaps of trouble if you're not careful. -- Lee Jones [李琼斯] Senior Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog