From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CEEAEC00A89 for ; Mon, 2 Nov 2020 10:33:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 777BA222E8 for ; Mon, 2 Nov 2020 10:33:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728253AbgKBKdu (ORCPT ); Mon, 2 Nov 2020 05:33:50 -0500 Received: from leonov.paulk.fr ([185.233.101.22]:56354 "EHLO leonov.paulk.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728005AbgKBKdt (ORCPT ); Mon, 2 Nov 2020 05:33:49 -0500 Received: from gagarine.paulk.fr (gagarine [192.168.1.127]) by leonov.paulk.fr (Postfix) with ESMTPS id B5595C0139; Mon, 2 Nov 2020 11:33:47 +0100 (CET) Received: by gagarine.paulk.fr (Postfix, from userid 114) id E98C6C1D7F; Mon, 2 Nov 2020 11:33:46 +0100 (CET) Received: from aptenodytes (unknown [192.168.1.1]) by gagarine.paulk.fr (Postfix) with ESMTPSA id C4F8EC1D7A; Mon, 2 Nov 2020 11:33:40 +0100 (CET) Date: Mon, 2 Nov 2020 11:33:40 +0100 From: Paul Kocialkowski To: Maxime Ripard Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Rob Herring , Chen-Yu Tsai , Matteo Scordino , Icenowy Zheng Subject: Re: [PATCH 8/9] dt-bindings: arm: sunxi: Add SL631 with IMX179 bindings Message-ID: <20201102103340.GD11809@aptenodytes> References: <20201031182137.1879521-1-contact@paulk.fr> <20201031182137.1879521-9-contact@paulk.fr> <20201102101333.4bm2lfqpqnbpyp63@gilmour.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201102101333.4bm2lfqpqnbpyp63@gilmour.lan> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi, On Mon 02 Nov 20, 11:13, Maxime Ripard wrote: > On Sat, Oct 31, 2020 at 07:21:36PM +0100, Paul Kocialkowski wrote: > > Document the compatible strings for the SL631 Action Camera with IMX179. > > > > Signed-off-by: Paul Kocialkowski > > --- > > Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documentation/devicetree/bindings/arm/sunxi.yaml > > index afa00268c7db..0fa0c0b5d89f 100644 > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml > > @@ -754,6 +754,12 @@ properties: > > - const: sinlinx,sina33 > > - const: allwinner,sun8i-a33 > > > > + - description: SL631 Action Camera with IMX179 > > + items: > > + - const: unknown,sl631-imx179 > > + - const: unknown,sl631 > > + - const: allwinner,sun8i-v3 > > + > > unknown is not a valid vendor (and you should explain why you picked > that vendor name in the first place). Ah right, it's not in the vendor prefixes. The rationale is that there is no indication of what the vendor might be on the PCB. Should I maybe use allwinner here? It looks derived from a V3 reference design anyway (at least the pin assignment matches e.g. Sochip's S3 EVB and other known S3 boards too apparently) so this could make sense. Cheers, Paul -- Developer of free digital technology and hardware support. Website: https://www.paulk.fr/ Coding blog: https://code.paulk.fr/ Git repositories: https://git.paulk.fr/ https://git.code.paulk.fr/