From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2CA5C388F9 for ; Mon, 2 Nov 2020 19:18:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 60A5A22268 for ; Mon, 2 Nov 2020 19:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604344731; bh=2COk/Twf5Bpxa+iVAFBfld4KkwJ3pWDPQIwLvp36L7s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=EnagHJ5r6bv5zy3IIV4xcXmJDYVK5LGV3fPwDp75vwOpRJGsFEhvg0/x8nDDEgdYb f2EHeQa5B7+XQmgSScQnFRiVR43NSD6u21ziV9rNttXL6NatB/axHaeIh3JubZnQoe lvC8C9XFG1Xgu7JWb7O2V408wml8McTo8GUrmA3Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725980AbgKBTSu convert rfc822-to-8bit (ORCPT ); Mon, 2 Nov 2020 14:18:50 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:41632 "EHLO mail-wr1-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725805AbgKBTSu (ORCPT ); Mon, 2 Nov 2020 14:18:50 -0500 Received: by mail-wr1-f51.google.com with SMTP id s9so15896399wro.8; Mon, 02 Nov 2020 11:18:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=/AolKp+qD2kV7vrOSz37k2pui3YJ81m/he5mhUN0SzY=; b=SU97rQLpHrFXCEQaycezhOeXA7nDzDIPHIEpX6KpncnKfEJUaQbs6XAFHYj7JS0HwS HvhQwaQ4lThMjdht07MZx7ZnUgZzGtMMQnmNi1UP2AdTqfSw0mWV1DfkfccRLzO0kpFl supAEYUPYQXx95KSxD5YwVrKxiaO2jtLDz1+e1y/axy+FxrBGsJSvp4JH0CXVWxxFas9 dfxIfFfjXGxQdv2pBtHicoPtpIqoaeTXncvxlB6aLytrI98tgTQMYJqH8JZw/Wka/bsJ VAMyNTVNLKEnuppFRaDDfTSJmCndWOlJJ96wZNKmhzgt0YQ/8ECF4VsAiXCL0IfCAc/2 AP4w== X-Gm-Message-State: AOAM533j2T84qQrbzLfo59N9o1+Wou71kCnzcGxy840VV1oUO4FKTa6S KAhOEgBenUDic/znSb5ecUE= X-Google-Smtp-Source: ABdhPJyWG1MbRtg3sM4utAw4q8GttcsFQafe2vaLETY8ms5hYTLWQHaql64zTnMxnaDPBknndO2XDA== X-Received: by 2002:a05:6000:12c2:: with SMTP id l2mr23468705wrx.249.1604344727744; Mon, 02 Nov 2020 11:18:47 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id 15sm449062wmg.1.2020.11.02.11.18.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 11:18:46 -0800 (PST) Date: Mon, 2 Nov 2020 20:18:45 +0100 From: Krzysztof Kozlowski To: Martin =?utf-8?Q?J=C3=BCcker?= Cc: linux-samsung-soc@vger.kernel.org, kgene@kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH 2/5] ARM: dts: add Samsung's exynos4412-based p4note boards Message-ID: <20201102191845.GA64695@kozik-lap> References: <20201031175836.47745-1-martin.juecker@gmail.com> <20201031175836.47745-3-martin.juecker@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: <20201031175836.47745-3-martin.juecker@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Sat, Oct 31, 2020 at 06:58:34PM +0100, Martin Jücker wrote: > The p4note family contains a couple of variants of the Galaxy Note 10.1 > tablet with mainly different modems. The GT-N8010/GT-N8013 is the wifi > only version. The subject is v1. Did you send correct patch? > > Signed-off-by: Martin Jücker > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/exynos4412-p4note-n8010.dts | 16 + > arch/arm/boot/dts/exynos4412-p4note.dtsi | 1128 +++++++++++++++++ > 3 files changed, 1145 insertions(+) > create mode 100644 arch/arm/boot/dts/exynos4412-p4note-n8010.dts > create mode 100644 arch/arm/boot/dts/exynos4412-p4note.dtsi > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 4572db3fa5ae..951853e55edb 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -195,6 +195,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \ > exynos4412-odroidx.dtb \ > exynos4412-odroidx2.dtb \ > exynos4412-origen.dtb \ > + exynos4412-p4note-n8010.dtb \ > exynos4412-smdk4412.dtb \ > exynos4412-tiny4412.dtb \ > exynos4412-trats2.dtb > diff --git a/arch/arm/boot/dts/exynos4412-p4note-n8010.dts b/arch/arm/boot/dts/exynos4412-p4note-n8010.dts > new file mode 100644 > index 000000000000..f99358750e01 > --- /dev/null > +++ b/arch/arm/boot/dts/exynos4412-p4note-n8010.dts > @@ -0,0 +1,16 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Samsung's Galaxy Note 10.1 - N801x (wifi only version) > + * > + * Copyright (c) 2020 Martin Jücker > + */ > + > +/dts-v1/; > +#include "exynos4412-p4note.dtsi" > + > +/ { > + model = "Samsung Galaxy Note 10.1 (GT-N8010/N8013) based on Exynos4412"; > + compatible = "samsung,n8010", "samsung,p4note", "samsung,exynos4412", "samsung,exynos4"; > + > + /* this is the base variant without any kind of modem */ > +}; > diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/dts/exynos4412-p4note.dtsi > new file mode 100644 > index 000000000000..15b6acbbecb2 > --- /dev/null > +++ b/arch/arm/boot/dts/exynos4412-p4note.dtsi > @@ -0,0 +1,1128 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Samsung's Exynos4412 based p4note device family base DT > + * > + * Copyright (c) 2020 Martin Jücker Multiple parts of this file look like copied from the existing ones. Few comments are the same. The v1 duplicated even few minor issues like not that good naming of nodes. It looks like it is not only based on existing sources, but uses parts of them directly. If it is true, then include the copyright of original work as well. https://www.gnu.org/prep/maintain/html_node/Copyright-Notices.html > + */ > + > +/dts-v1/; > +#include "exynos4412.dtsi" > +#include "exynos4412-ppmu-common.dtsi" > + > +#include > +#include > +#include > +#include > +#include > + > +/ { > + compatible = "samsung,p4note", "samsung,exynos4412", "samsung,exynos4"; > + > + memory@40000000 { > + device_type = "memory"; > + reg = <0x40000000 0x80000000>; > + }; > + > + chosen { > + stdout-path = &serial_2; > + }; > + > + firmware@204f000 { > + compatible = "samsung,secure-firmware"; > + reg = <0x0204F000 0x1000>; > + }; > + > + fixed-rate-clocks { > + xxti { > + compatible = "samsung,clock-xxti"; > + clock-frequency = <0>; > + }; > + > + xusbxti { > + compatible = "samsung,clock-xusbxti"; > + clock-frequency = <24000000>; > + }; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&gpio_keys>; > + > + key-down { > + gpios = <&gpx2 2 GPIO_ACTIVE_LOW>; > + linux,code = ; > + label = "volume down"; > + debounce-interval = <10>; > + }; > + > + key-up { > + gpios = <&gpx3 3 GPIO_ACTIVE_LOW>; > + linux,code = ; > + label = "volume up"; > + debounce-interval = <10>; > + }; > + > + key-power { > + gpios = <&gpx2 7 GPIO_ACTIVE_LOW>; > + linux,code = ; > + label = "power"; > + debounce-interval = <10>; > + wakeup-source; > + }; > + }; > + > + voltage-regulator-1 { > + compatible = "regulator-fixed"; > + regulator-name = "TSP_LDO1"; > + pinctrl-names = "default"; > + pinctrl-0 = <&tsp_reg_gpio_1>; > + gpios = <&gpm4 5 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + regulator-always-on; > + }; > + > + voltage-regulator-2 { > + compatible = "regulator-fixed"; > + regulator-name = "TSP_LDO2"; > + pinctrl-names = "default"; > + pinctrl-0 = <&tsp_reg_gpio_2>; > + gpios = <&gpb 5 GPIO_ACTIVE_HIGH>; > + enable-active-high; > + regulator-always-on; > + }; > + > + voltage-regulator-3 { > + compatible = "regulator-fixed"; > + regulator-name = "TSP_LDO3"; > + pinctrl-names = "default"; > + pinctrl-0 = <&tsp_reg_gpio_3>; > + gpios = <&gpb 7 GPIO_ACTIVE_HIGH>; > + startup-delay-us = <20000>; > + enable-active-high; > + regulator-always-on; > + }; > + > + wlan_pwrseq: sdhci3-pwrseq { > + compatible = "mmc-pwrseq-simple"; > + reset-gpios = <&gpm3 5 GPIO_ACTIVE_LOW>; > + pinctrl-0 = <&wifi_reset>; > + pinctrl-names = "default"; > + clocks = <&max77686 MAX77686_CLK_PMIC>; > + clock-names = "ext_clock"; > + }; > + > + i2c-gpio-1 { > + compatible = "i2c-gpio"; > + sda-gpios = <&gpy2 4 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > + scl-gpios = <&gpy2 5 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > + i2c-gpio,delay-us = <2>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + magnetometer@c { > + compatible = "asahi-kasei,ak8975"; > + reg = <0x0c>; > + pinctrl-0 = <&ak8975_irq>; > + pinctrl-names = "default"; > + interrupt-parent = <&gpm4>; > + interrupts = <7 IRQ_TYPE_EDGE_RISING>; > + }; > + }; > + > + i2c-gpio-2 { > + compatible = "i2c-gpio"; > + sda-gpios = <&gpy0 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > + scl-gpios = <&gpy0 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > + i2c-gpio,delay-us = <2>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + fuel-gauge@36 { > + compatible = "maxim,max17042"; > + reg = <0x36>; > + pinctrl-0 = <&fuel_alert_irq>; > + pinctrl-names = "default"; > + interrupt-parent = <&gpx2>; > + interrupts = <3 IRQ_TYPE_EDGE_FALLING>; > + maxim,rsns-microohm = <10000>; > + maxim,over-heat-temp = <600>; > + maxim,over-volt = <4300>; > + }; > + }; > + > + i2c-gpio-3 { > + compatible = "i2c-gpio"; > + sda-gpios = <&gpm4 1 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > + scl-gpios = <&gpm4 0 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>; > + i2c-gpio,delay-us = <5>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + adc@41 { > + compatible = "st,stmpe811"; > + reg = <0x41>; > + pinctrl-0 = <&stmpe_adc_irq>; > + pinctrl-names = "default"; > + interrupt-parent = <&gpx0>; > + interrupts = <1 IRQ_TYPE_LEVEL_LOW>; > + interrupt-controller; > + irq-trigger = <0x1>; > + st,adc-freq = <3>; > + st,mod-12b = <1>; > + st,ref-sel = <0>; > + st,sample-time = <3>; > + > + stmpe_adc { > + compatible = "st,stmpe-adc"; > + #io-channel-cells = <1>; > + st,norequest-mask = <0x2F>; > + }; > + }; > + }; > +}; > + > +&adc { > + vdd-supply = <&ldo3_reg>; > + /* not verified */ > + status = "okay"; > +}; > + > +&bus_dmc { > + devfreq-events = <&ppmu_dmc0_3>, <&ppmu_dmc1_3>; > + vdd-supply = <&buck1_reg>; > + status = "okay"; > +}; > + > +&bus_acp { > + devfreq = <&bus_dmc>; > + status = "okay"; > +}; > + > +&bus_c2c { > + devfreq = <&bus_dmc>; > + status = "okay"; > +}; > + > +&bus_leftbus { > + devfreq-events = <&ppmu_leftbus_3>, <&ppmu_rightbus_3>; > + vdd-supply = <&buck3_reg>; > + status = "okay"; > +}; > + > +&bus_rightbus { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; > + > +&bus_display { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; > + > +&bus_fsys { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; > + > +&bus_peri { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; > + > +&bus_mfc { > + devfreq = <&bus_leftbus>; > + status = "okay"; > +}; > + > +&cpu0 { > + cpu0-supply = <&buck2_reg>; > +}; > + > +&cpu_thermal { > + cooling-maps { > + map0 { > + /* Corresponds to 800MHz at freq_table */ > + cooling-device = <&cpu0 7 7>, <&cpu1 7 7>, <&cpu2 7 7>, <&cpu3 7 7>; > + }; > + map1 { > + /* Corresponds to 200MHz at freq_table */ > + cooling-device = <&cpu0 13 13>, <&cpu1 13 13>, <&cpu2 13 13>, <&cpu3 13 13>; This is too long. Please split it at 80 with indentation of next line starting at < from the previous one. > + }; > + }; > +}; > + > +&exynos_usbphy { > + status = "okay"; > +}; > + > +&fimd { > + pinctrl-0 = <&lcd_clk &lcd_data24 &pwm1_out>; > + pinctrl-names = "default"; > + status = "okay"; > + > + display-timings { > + timing0 { > + clock-frequency = <66666666>; > + hactive = <1280>; > + vactive = <800>; > + hfront-porch = <18>; > + hback-porch = <36>; > + hsync-len = <16>; > + vback-porch = <16>; > + vfront-porch = <4>; > + vsync-len = <3>; > + hsync-active = <1>; > + }; > + }; What happened with Marek's comment about this? Best regards, Krzysztof