From: Andrew Lunn <andrew@lunn.ch>
To: Dan Murphy <dmurphy@ti.com>
Cc: Jakub Kicinski <kuba@kernel.org>,
davem@davemloft.net, f.fainelli@gmail.com, hkallweit1@gmail.com,
robh@kernel.org, devicetree@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the DP83TD510 Ethernet PHY
Date: Tue, 3 Nov 2020 18:38:17 +0100 [thread overview]
Message-ID: <20201103173817.GP1042051@lunn.ch> (raw)
In-Reply-To: <d51ef446-1528-5d3f-8548-831598a005a7@ti.com>
> > > > drivers/net/phy/dp83td510.c:70:11: warning: symbol 'dp83td510_feature_array' was not declared. Should it be static?
> > > I did not see this warning. Did you use W=1?
> > I _think_ that one is W=1. All the PHY drivers are W=1 clean, and i
> > want to keep it that way. And i hope to make it the default in a lot
> > of the network code soon.
> OK I built with the W=1 before submission I did not see this but I will try
> some other things.
Then it might be sparse. Try C=1.
Andrew
next prev parent reply other threads:[~2020-11-03 17:38 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-30 17:29 [PATCH net-next v3 0/4] DP83TD510 Single Pair 10Mbps Ethernet PHY Dan Murphy
2020-10-30 17:29 ` [PATCH net-next v3 1/4] ethtool: Add 10base-T1L link mode entries Dan Murphy
2020-10-30 19:43 ` Andrew Lunn
2020-11-05 2:42 ` Florian Fainelli
2020-10-30 17:29 ` [PATCH net-next v3 2/4] dt-bindings: net: Add Rx/Tx output configuration for 10base T1L Dan Murphy
2020-10-30 19:56 ` Andrew Lunn
2020-11-03 16:52 ` Dan Murphy
2020-11-03 17:07 ` Andrew Lunn
2020-11-04 22:08 ` Rob Herring
2020-10-30 17:29 ` [PATCH net-next v3 3/4] dt-bindings: dp83td510: Add binding for DP83TD510 Ethernet PHY Dan Murphy
2020-10-31 9:27 ` Ioana Ciornei
2020-11-02 17:12 ` Rob Herring
2020-10-30 17:29 ` [PATCH net-next v3 4/4] net: phy: dp83td510: Add support for the " Dan Murphy
2020-10-30 20:15 ` Andrew Lunn
2020-11-03 17:07 ` Dan Murphy
2020-11-03 17:18 ` Andrew Lunn
2020-11-03 17:35 ` Dan Murphy
2020-11-05 3:03 ` Florian Fainelli
2020-10-30 23:03 ` Jakub Kicinski
2020-11-03 17:09 ` Dan Murphy
2020-11-03 17:21 ` Andrew Lunn
2020-11-03 17:23 ` Dan Murphy
2020-11-03 17:38 ` Andrew Lunn [this message]
2020-10-31 9:18 ` Ioana Ciornei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201103173817.GP1042051@lunn.ch \
--to=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=f.fainelli@gmail.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).