From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B65C2D0A3 for ; Tue, 3 Nov 2020 22:51:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2840320756 for ; Tue, 3 Nov 2020 22:51:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604443910; bh=ZTc1hgZLMSAMqmuiHXxbYJqFXykktHOtVDml/cKUNQI=; h=Date:From:To:Cc:Subject:In-Reply-To:List-ID:From; b=S/RdZ6rx5rK7WA7fkg0IG5ixcOb99EHU4H1IBRrbZzGcMl9xfxOmKY3QhHW8MBHNV PbF5FJ3F0HEL4TCHUU7DyudlANS3weOeKzminu8QlfOLVjIj3VQbuTkpo1F3/HttxN KEJNloTPwZSZVMhDR5EqteyXQRBj8Sh37KE6UA8Y= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729964AbgKCWvt (ORCPT ); Tue, 3 Nov 2020 17:51:49 -0500 Received: from mail.kernel.org ([198.145.29.99]:36494 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729575AbgKCWvt (ORCPT ); Tue, 3 Nov 2020 17:51:49 -0500 Received: from localhost (230.sub-72-107-127.myvzw.com [72.107.127.230]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 532222074F; Tue, 3 Nov 2020 22:51:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604443908; bh=ZTc1hgZLMSAMqmuiHXxbYJqFXykktHOtVDml/cKUNQI=; h=Date:From:To:Cc:Subject:In-Reply-To:From; b=K6DzT0ksd3lJgCr+h18+p8FlRdsdY5B8CYGfhGx6IshX9G71zdkA9OJEr5+v+WnDG W3iKWYFFhiCFyIbrWhP2aLH+7d5F0y6cuF5faq3ECbKRZHQPrufds4Y6x+gApQdyqF tJnQfARtjZ6R8PTljKHYcG1GsqgzSnRWzcTbsJOU= Date: Tue, 3 Nov 2020 16:51:47 -0600 From: Bjorn Helgaas To: Chuanjia Liu Cc: Rob Herring , Lorenzo Pieralisi , devicetree@vger.kernel.org, Ryder Lee , Frank Wunderlich , linux-pci@vger.kernel.org, Matthias Brugger , linux-mediatek@lists.infradead.org, yong.wu@mediatek.com, Bjorn Helgaas , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v7 4/4] ARM: dts: mediatek: Modified MT7629 PCIe node Message-ID: <20201103225147.GA272037@bjorn-Precision-5520> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201029081513.10562-5-chuanjia.liu@mediatek.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org This subject line is pointless. Every patch modifies something. Give us a hint about what you modified and why. And use the present tense verb, i.e., "Modify ...", not "Modified". Probably "Add" would be better than "Modify". Or "Update" with some meaningful description of the update. On Thu, Oct 29, 2020 at 04:15:13PM +0800, Chuanjia Liu wrote: > Remove unused property and add pciecfg node. Apparently this also removes "subsys" from the "reg" property. And removes an interrupt. And adds "pcie_irq". > Signed-off-by: Chuanjia Liu > Acked-by: Ryder Lee > --- > arch/arm/boot/dts/mt7629-rfb.dts | 3 ++- > arch/arm/boot/dts/mt7629.dtsi | 22 ++++++++++++---------- > 2 files changed, 14 insertions(+), 11 deletions(-) > > diff --git a/arch/arm/boot/dts/mt7629-rfb.dts b/arch/arm/boot/dts/mt7629-rfb.dts > index 9980c10c6e29..eb536cbebd9b 100644 > --- a/arch/arm/boot/dts/mt7629-rfb.dts > +++ b/arch/arm/boot/dts/mt7629-rfb.dts > @@ -140,9 +140,10 @@ > }; > }; > > -&pcie { > +&pcie1 { > pinctrl-names = "default"; > pinctrl-0 = <&pcie_pins>; > + status = "okay"; > }; > > &pciephy1 { > diff --git a/arch/arm/boot/dts/mt7629.dtsi b/arch/arm/boot/dts/mt7629.dtsi > index 5cbb3d244c75..6d6397f0c2fc 100644 > --- a/arch/arm/boot/dts/mt7629.dtsi > +++ b/arch/arm/boot/dts/mt7629.dtsi > @@ -360,16 +360,20 @@ > #reset-cells = <1>; > }; > > - pcie: pcie@1a140000 { > + pciecfg: pciecfg@1a140000 { > + compatible = "mediatek,generic-pciecfg", "syscon"; > + reg = <0x1a140000 0x1000>; > + }; > + > + pcie1: pcie@1a145000 { > compatible = "mediatek,mt7629-pcie"; > device_type = "pci"; > - reg = <0x1a140000 0x1000>, > - <0x1a145000 0x1000>; > - reg-names = "subsys","port1"; > + reg = <0x1a145000 0x1000>; > + reg-names = "port1"; > #address-cells = <3>; > #size-cells = <2>; > - interrupts = , > - ; > + interrupts = ; > + interrupt-names = "pcie_irq"; > clocks = <&pciesys CLK_PCIE_P1_MAC_EN>, > <&pciesys CLK_PCIE_P0_AHB_EN>, > <&pciesys CLK_PCIE_P1_AUX_EN>, > @@ -390,21 +394,19 @@ > power-domains = <&scpsys MT7622_POWER_DOMAIN_HIF0>; > bus-range = <0x00 0xff>; > ranges = <0x82000000 0 0x20000000 0x20000000 0 0x10000000>; > + status = "disabled"; > > - pcie1: pcie@1,0 { > - device_type = "pci"; > + slot1: pcie@1,0 { > reg = <0x0800 0 0 0 0>; > #address-cells = <3>; > #size-cells = <2>; > #interrupt-cells = <1>; > ranges; > - num-lanes = <1>; > interrupt-map-mask = <0 0 0 7>; > interrupt-map = <0 0 0 1 &pcie_intc1 0>, > <0 0 0 2 &pcie_intc1 1>, > <0 0 0 3 &pcie_intc1 2>, > <0 0 0 4 &pcie_intc1 3>; > - > pcie_intc1: interrupt-controller { > interrupt-controller; > #address-cells = <0>; > -- > 2.18.0 > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel