From: Rob Herring <robh@kernel.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v5 1/3] dt-bindings: dmaengine: Document qcom,gpi dma binding
Date: Wed, 4 Nov 2020 13:00:59 -0600 [thread overview]
Message-ID: <20201104190059.GA3950437@bogus> (raw)
In-Reply-To: <20201103112544.674566-2-vkoul@kernel.org>
On Tue, 03 Nov 2020 16:55:42 +0530, Vinod Koul wrote:
> Add devicetree binding documentation for GPI DMA controller
> implemented on Qualcomm SoCs
>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
> .../devicetree/bindings/dma/qcom,gpi.yaml | 90 +++++++++++++++++++
> include/dt-bindings/dma/qcom-gpi.h | 11 +++
> 2 files changed, 101 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/dma/qcom,gpi.yaml
> create mode 100644 include/dt-bindings/dma/qcom-gpi.h
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/qcom,gpi.yaml: properties: {'enum': ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'if', 'items', 'maxItems', 'maximum', 'minItems', 'minimum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'propertyNames', 'required', 'then', 'unevaluatedProperties']} is not allowed for 'additionalProperties'
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/dma/qcom,gpi.yaml: ignoring, error in schema: properties
warning: no schema found in file: ./Documentation/devicetree/bindings/dma/qcom,gpi.yaml
See https://patchwork.ozlabs.org/patch/1392940
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-11-04 19:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-03 11:25 [PATCH v5 0/3] dmaengine: Add support for QCOM GSI dma controller Vinod Koul
2020-11-03 11:25 ` [PATCH v5 1/3] dt-bindings: dmaengine: Document qcom,gpi dma binding Vinod Koul
2020-11-04 19:00 ` Rob Herring [this message]
2020-11-03 11:25 ` [PATCH v5 2/3] dmaengine: add peripheral configuration Vinod Koul
2020-11-03 11:25 ` [PATCH v5 3/3] dmaengine: qcom: Add GPI dma driver Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104190059.GA3950437@bogus \
--to=robh@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).