From: Rob Herring <robh@kernel.org>
To: Khalil Blaiech <kblaiech@nvidia.com>
Cc: wsa+renesas@sang-engineering.com, devicetree@vger.kernel.org,
robh+dt@kernel.org, linux-i2c@vger.kernel.org
Subject: Re: [PATCH i2c-next v2 6/6] dt-bindings: i2c: Convert DT file to YAML schema
Date: Wed, 4 Nov 2020 13:04:27 -0600 [thread overview]
Message-ID: <20201104190427.GA3957380@bogus> (raw)
In-Reply-To: <c81a0679413dd77e68bdf7e3023d1a54e62f26ea.1604432921.git.kblaiech@nvidia.com>
On Tue, 03 Nov 2020 14:56:08 -0500, Khalil Blaiech wrote:
> Write the devicetree binding text file associated with
> the Mellanox BlueField I2C controller in schema file,
> JSON compatible subset of YAML. Besides, add an entry
> within MAINTAINERS file.
>
> Reviewed-by: Leon Romanovsky <leonro@nvidia.com>
> Signed-off-by: Khalil Blaiech <kblaiech@nvidia.com>
> ---
> .../devicetree/bindings/i2c/mellanox,i2c-mlxbf.txt | 42 ------------
> .../bindings/i2c/mellanox,i2c-mlxbf.yaml | 80 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 3 files changed, 81 insertions(+), 42 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.txt
> create mode 100644 Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml: More than one condition true in oneOf schema:
{'oneOf': [{'required': ['unevaluatedProperties']},
{'required': ['additionalProperties']}]}
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml: ignoring, error in schema:
warning: no schema found in file: ./Documentation/devicetree/bindings/i2c/mellanox,i2c-mlxbf.yaml
See https://patchwork.ozlabs.org/patch/1393383
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
prev parent reply other threads:[~2020-11-04 19:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1604432921.git.kblaiech@nvidia.com>
2020-11-03 19:56 ` [PATCH i2c-next v2 6/6] dt-bindings: i2c: Convert DT file to YAML schema Khalil Blaiech
2020-11-03 23:41 ` Khalil Blaiech
2020-11-04 2:59 ` Rob Herring
2020-11-04 13:44 ` Khalil Blaiech
2020-11-06 14:53 ` Wolfram Sang
2020-11-06 14:56 ` Khalil Blaiech
2020-11-04 19:04 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104190427.GA3957380@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kblaiech@nvidia.com \
--cc=linux-i2c@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).