From: Rob Herring <robh@kernel.org>
To: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
Cc: git@xilinx.com, mturquette@baylibre.com, sboyd@kernel.org,
devicetree@vger.kernel.org, gregkh@linuxfoundation.org,
devel@driverdev.osuosl.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v7 1/7] dt-bindings: add documentation of xilinx clocking wizard
Date: Wed, 4 Nov 2020 13:11:46 -0600 [thread overview]
Message-ID: <20201104191146.GA3967018@bogus> (raw)
In-Reply-To: <1604502407-14352-2-git-send-email-shubhrajyoti.datta@xilinx.com>
On Wed, 04 Nov 2020 20:36:41 +0530, Shubhrajyoti Datta wrote:
> Add the devicetree binding for the xilinx clocking wizard.
>
> Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
> ---
> v6:
> Fix a yaml warning
> v7:
> Add vendor prefix speed-grade
>
> .../bindings/clock/xlnx,clocking-wizard.yaml | 65 ++++++++++++++++++++++
> 1 file changed, 65 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
./Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml:21:7: [warning] wrong indentation: expected 4 but found 6 (indentation)
./Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml:38:7: [warning] wrong indentation: expected 4 but found 6 (indentation)
./Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.yaml:40:5: [error] syntax error: expected <block end>, but found '<block mapping start>' (syntax)
dtschema/dtc warnings/errors:
Traceback (most recent call last):
File "/usr/local/bin/dt-extract-example", line 45, in <module>
binding = yaml.load(open(args.yamlfile, encoding='utf-8').read())
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 343, in load
return constructor.get_single_data()
File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 111, in get_single_data
node = self.composer.get_single_node()
File "_ruamel_yaml.pyx", line 706, in _ruamel_yaml.CParser.get_single_node
File "_ruamel_yaml.pyx", line 724, in _ruamel_yaml.CParser._compose_document
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 889, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 775, in _ruamel_yaml.CParser._compose_node
File "_ruamel_yaml.pyx", line 891, in _ruamel_yaml.CParser._compose_mapping_node
File "_ruamel_yaml.pyx", line 904, in _ruamel_yaml.CParser._parse_next_event
ruamel.yaml.parser.ParserError: while parsing a block mapping
in "<unicode string>", line 20, column 3
did not find expected key
in "<unicode string>", line 40, column 5
make[1]: *** [Documentation/devicetree/bindings/Makefile:20: Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.example.dts] Error 1
make[1]: *** Deleting file 'Documentation/devicetree/bindings/clock/xlnx,clocking-wizard.example.dts'
make[1]: *** Waiting for unfinished jobs....
make[1]: *** [Documentation/devicetree/bindings/Makefile:59: Documentation/devicetree/bindings/processed-schema-examples.json] Error 123
make: *** [Makefile:1364: dt_binding_check] Error 2
See https://patchwork.ozlabs.org/patch/1394053
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-11-04 19:11 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-04 15:06 [PATCH v7 0/7] clk: clk-wizard: clock-wizard: Driver updates Shubhrajyoti Datta
2020-11-04 15:06 ` [PATCH v7 1/7] dt-bindings: add documentation of xilinx clocking wizard Shubhrajyoti Datta
2020-11-04 19:11 ` Rob Herring [this message]
2020-11-04 19:15 ` Rob Herring
2020-11-04 15:06 ` [PATCH v7 2/7] clk: clock-wizard: Add the clockwizard to clk directory Shubhrajyoti Datta
2020-11-04 15:06 ` [PATCH v7 3/7] clk: clock-wizard: Fix kernel-doc warning Shubhrajyoti Datta
2020-11-04 15:06 ` [PATCH v7 4/7] clk: clock-wizard: Add support for dynamic reconfiguration Shubhrajyoti Datta
2020-11-04 15:06 ` [PATCH v7 5/7] clk: clock-wizard: Add support for fractional support Shubhrajyoti Datta
2020-11-04 15:06 ` [PATCH v7 6/7] clk: clock-wizard: Remove the hardcoding of the clock outputs Shubhrajyoti Datta
2020-11-04 15:06 ` [PATCH v7 7/7] clk: clock-wizard: Update the fixed factor divisors Shubhrajyoti Datta
2020-12-13 5:36 ` [PATCH v7 0/7] clk: clk-wizard: clock-wizard: Driver updates Stephen Boyd
2021-01-21 14:40 ` Michal Simek
2020-12-15 9:13 ` Michal Simek
2020-12-15 19:10 ` Stephen Boyd
2021-01-21 14:39 ` Miquel Raynal
2021-02-12 14:20 ` Michal Simek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104191146.GA3967018@bogus \
--to=robh@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-clk@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@kernel.org \
--cc=shubhrajyoti.datta@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).