devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alice Guo <alice.guo@nxp.com>
Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
	linux-imx@nxp.com, peng.fan@nxp.com, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID
Date: Thu, 5 Nov 2020 09:25:43 +0100	[thread overview]
Message-ID: <20201105082543.GA17569@kozik-lap> (raw)
In-Reply-To: <20201105072629.24175-1-alice.guo@nxp.com>

On Thu, Nov 05, 2020 at 03:26:26PM +0800, Alice Guo wrote:
> Add DT Binding doc for the Unique ID of i.MX 8M series.
> 
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
> ---
>  .../devicetree/bindings/arm/fsl.yaml          | 33 +++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index e4db0f9ed664..0419f078502b 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -901,6 +901,39 @@ properties:
>                - fsl,s32v234-evb           # S32V234-EVB2 Customer Evaluation Board
>            - const: fsl,s32v234
> 
> +  soc:
> +    description:
> +      i.MX8M Family SoC must provide a soc node in the root of the device tree,
> +      representing the System-on-Chip since these test chips are rather complex.
> +    type: object
> +    properties:
> +      compatible:
> +        oneOf:
> +          - items:
> +              - const: fsl,imx8mm-soc
> +              - const: simple-bus
> +          - items:
> +              - const: fsl,imx8mn-soc
> +              - const: simple-bus
> +          - items:
> +              - const: fsl,imx8mp-soc
> +              - const: simple-bus
> +          - items:
> +              - const: fsl,imx8mq-soc
> +              - const: simple-bus
> +
> +      nvmem-cells:
> +        maxItems: 1
> +        description: Phandle to the SOC Unique ID provided by a nvmem node
> +
> +      nvmem-cells-names:
> +        const: soc_unique_id
> +
> +    required:
> +      - compatible
> +      - nvmem-cells
> +      - nvmem-cell-names
> +

Did you actually test it? I see multiple errors with this patch.
fsl-ls1012a-frdm.dt.yaml: /: soc:compatible: ['simple-bus'] is not valid under any of the given schemas

Best regards,
Krzysztof


  parent reply	other threads:[~2020-11-05  8:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-05  7:26 [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Alice Guo
2020-11-05  7:26 ` [PATCH v2 2/4] arm64: dts: imx8m: add compatible string to .dtsi file Alice Guo
2020-11-05  7:26 ` [PATCH v2 3/4] arm64: dts: imx8m: add nvmem-cell related stuff Alice Guo
2020-11-05  7:26 ` [PATCH v2 4/4] soc: imx8m: change to use platform driver Alice Guo
2020-11-05  9:06   ` Krzysztof Kozlowski
2020-11-06 10:35     ` [EXT] " Alice Guo
2020-11-06 20:07       ` Krzysztof Kozlowski
2020-11-05  8:25 ` Krzysztof Kozlowski [this message]
2020-11-05 12:19   ` [EXT] Re: [PATCH v2 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Alice Guo
2020-11-05 12:24     ` Krzysztof Kozlowski
2020-11-09 19:10 ` Rob Herring
2020-11-10  5:25   ` Peng Fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201105082543.GA17569@kozik-lap \
    --to=krzk@kernel.org \
    --cc=alice.guo@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peng.fan@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).