From: Pavel Machek <pavel@ucw.cz>
To: Amireddy Mallikarjuna reddy <mallikarjunax.reddy@linux.intel.com>
Cc: linux-leds@vger.kernel.org, dmurphy@ti.com,
devicetree@vger.kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, cheol.yong.kim@intel.com,
qi-ming.wu@intel.com, malliamireddy009@gmail.com,
yixin.zhu@intel.com
Subject: Re: [PATCH v1 1/2] dt-bindings: leds: Add bindings for intel LGM SOC
Date: Thu, 5 Nov 2020 10:52:57 +0100 [thread overview]
Message-ID: <20201105095257.GA7994@amd> (raw)
In-Reply-To: <c9c963a2d03fbd03bd21f71f3d776ac5800cf6cc.1604331498.git.mallikarjunax.reddy@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 1275 bytes --]
On Thu 2020-11-05 17:43:50, Amireddy Mallikarjuna reddy wrote:
> Add DT bindings YAML schema for SSO controller driver
> of Lightning Mountain(LGM) SoC.
>
intel -> Intel in the title.
"Lightning Mountain(LGM)" -> 'Lightning Mountain (LGM)"
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/leds-lgm.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Intel LGM Soc LED SSO driver
Please spell out LGM and SSO here. Soc -> SoC?
> + intel,sso-brightness:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: brightness level of the LED.
> + minimum: 0
> + maximum: 255
?
> + intel,sso-hw-trigger:
> + type: boolean
> + description: This property indicates Hardware driven/control LED.
Why is this intel specific?
> + intel,sso-hw-blink:
> + type: boolean
> + description: This property indicates Enable LED blink by Hardware.
?
> + intel,sso-blink-rate:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description: LED HW blink frequency.
?
Best regards,
Pavel
--
http://www.livejournal.com/~pavelmachek
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]
next prev parent reply other threads:[~2020-11-05 9:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 9:43 [PATCH v1 1/2] dt-bindings: leds: Add bindings for intel LGM SOC Amireddy Mallikarjuna reddy
2020-11-05 9:43 ` [PATCH v1 2/2] leds: lgm: Add LED controller driver for LGM Soc Amireddy Mallikarjuna reddy
2020-11-05 10:11 ` Pavel Machek
2020-11-11 22:34 ` Reddy, MallikarjunaX
2020-11-05 9:52 ` Pavel Machek [this message]
2020-11-11 22:34 ` [PATCH v1 1/2] dt-bindings: leds: Add bindings for intel LGM SOC Reddy, MallikarjunaX
2020-11-05 18:48 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201105095257.GA7994@amd \
--to=pavel@ucw.cz \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=malliamireddy009@gmail.com \
--cc=mallikarjunax.reddy@linux.intel.com \
--cc=qi-ming.wu@intel.com \
--cc=robh+dt@kernel.org \
--cc=yixin.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).