From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 028A6C388F9 for ; Sun, 8 Nov 2020 10:55:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B0988206ED for ; Sun, 8 Nov 2020 10:55:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727949AbgKHKzk (ORCPT ); Sun, 8 Nov 2020 05:55:40 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:52470 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727348AbgKHKzk (ORCPT ); Sun, 8 Nov 2020 05:55:40 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id D376220025; Sun, 8 Nov 2020 11:55:36 +0100 (CET) Date: Sun, 8 Nov 2020 11:55:35 +0100 From: Sam Ravnborg To: Alexandru Gagniuc Cc: dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, Jernej Skrabec , Mauro Carvalho Chehab , Neil Armstrong , David Airlie , Mark Brown , Jonas Karlman , open list , Andrzej Hajda , Rob Herring , Thomas Bogendoerfer , Laurent Pinchart Subject: Re: [PATCH v3 2/3] drm/bridge: sii902x: Enable I/O and core VCC supplies if present Message-ID: <20201108105535.GB1161483@ravnborg.org> References: <20200928173056.1674274-1-mr.nuke.me@gmail.com> <20201020221501.260025-2-mr.nuke.me@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201020221501.260025-2-mr.nuke.me@gmail.com> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=VbvZwmh9 c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=pGLkceISAAAA:8 a=f2O8UAJn3HDJhdU-9UYA:9 a=CjuIK1q_8ugA:10 Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Alexandru On Tue, Oct 20, 2020 at 05:14:58PM -0500, Alexandru Gagniuc wrote: > On the SII9022, the IOVCC and CVCC12 supplies must reach the correct > voltage before the reset sequence is initiated. On most boards, this > assumption is true at boot-up, so initialization succeeds. > > However, when we try to initialize the chip with incorrect supply > voltages, it will not respond to I2C requests. sii902x_probe() fails > with -ENXIO. > > To resolve this, look for the "iovcc" and "cvcc12" regulators, and > make sure they are enabled before starting the reset sequence. If > these supplies are not available in devicetree, then they will default > to dummy-regulator. In that case everything will work like before. > > This was observed on a STM32MP157C-DK2 booting in u-boot falcon mode. > On this board, the supplies would be set by the second stage > bootloader, which does not run in falcon mode. > > Signed-off-by: Alexandru Gagniuc Thanks, applied series to drm-misc-next. I fixed two checkpatch --strict warnings while applying. Sam