From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Wan Ahmad Zainie <wan.ahmad.zainie.wan.mohamad@intel.com>
Cc: kishon@ti.com, vkoul@kernel.org, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
mgross@linux.intel.com, lakshmi.bai.raja.subramanian@intel.com
Subject: Re: [PATCH v2 2/2] phy: intel: Add Keem Bay USB PHY support
Date: Mon, 9 Nov 2020 13:41:02 +0200 [thread overview]
Message-ID: <20201109114102.GY4077@smile.fi.intel.com> (raw)
In-Reply-To: <20201109031654.22443-3-wan.ahmad.zainie.wan.mohamad@intel.com>
On Mon, Nov 09, 2020 at 11:16:54AM +0800, Wan Ahmad Zainie wrote:
> Add support for USB PHY on Intel Keem Bay SoC.
...
> +config PHY_INTEL_KEEMBAY_USB
> + tristate "Intel Keem Bay USB PHY driver"
> + depends on ARCH_KEEMBAY || (ARM64 && COMPILE_TEST)
> + depends on OF && HAS_IOMEM
Do you really need dependency to OF (yes, I see that it will be not functional,
but still can be compile tested)?
> + select GENERIC_PHY
> + select REGMAP_MMIO
> + help
> + Choose this option if you have an Intel Keem Bay SoC.
> +
> + To compile this driver as a module, choose M here: the module
> + will be called phy-keembay-usb.ko.
...
> +#include <linux/bitfield.h>
> +#include <linux/bits.h>
> +#include <linux/clk.h>
> +#include <linux/delay.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
No evidence of anything being used in this code.
mod_devicetable.h is missed, though.
> +#include <linux/phy/phy.h>
> +#include <linux/platform_device.h>
> +#include <linux/regmap.h>
...
> + usleep_range(30, 50);
Why 30-50?
...
> + usleep_range(20, 50);
Why these numbers?
...
> + usleep_range(2, 10);
Ditto.
...
> + usleep_range(20, 50);
Ditto.
...
> + struct device_node *np = dev->of_node;
It's being used only once and it doesn't bring any benefit.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-11-09 11:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 3:16 [PATCH v2 0/2] phy: intel: Add Keem Bay USB PHY support Wan Ahmad Zainie
2020-11-09 3:16 ` [PATCH v2 1/2] dt-bindings: phy: Add Intel Keem Bay USB PHY bindings Wan Ahmad Zainie
2020-11-09 3:16 ` [PATCH v2 2/2] phy: intel: Add Keem Bay USB PHY support Wan Ahmad Zainie
2020-11-09 11:41 ` Andy Shevchenko [this message]
2020-11-11 9:28 ` Wan Mohamad, Wan Ahmad Zainie
2020-11-11 9:49 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109114102.GY4077@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=lakshmi.bai.raja.subramanian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgross@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
--cc=wan.ahmad.zainie.wan.mohamad@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).