From: Rob Herring <robh@kernel.org>
To: Shane Chien <shane.chien@mediatek.com>
Cc: wsd_upstream@mediatek.com, chipeng.chang@mediatek.com,
Rob Herring <robh+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-kernel@vger.kernel.org, jiaxin.yu@mediatek.com,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v2 2/2] dt-bindings: mediatek: mt6359: Add new property for mt6359
Date: Mon, 9 Nov 2020 09:43:30 -0600 [thread overview]
Message-ID: <20201109154330.GA1343292@bogus> (raw)
In-Reply-To: <1604914209-9174-3-git-send-email-shane.chien@mediatek.com>
On Mon, 09 Nov 2020 17:30:09 +0800, Shane Chien wrote:
> From: "Shane.Chien" <shane.chien@mediatek.com>
>
> This patch add "LDO_VAUD18-supply" property to
> control vaud18 regulator. It is labeled as required
> due to mt6359 audio path always need to enable vaud18.
>
> Signed-off-by: Shane.Chien <shane.chien@mediatek.com>
> ---
> .../devicetree/bindings/sound/mt6359.yaml | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/mt6359.yaml: properties:LDO_VAUD18-supply: Additional properties are not allowed ('ref' was unexpected)
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/mt6359.yaml: properties:LDO_VAUD18-supply: 'ref' is not one of ['$ref', 'additionalItems', 'additionalProperties', 'allOf', 'anyOf', 'const', 'contains', 'default', 'dependencies', 'deprecated', 'description', 'else', 'enum', 'exclusiveMaximum', 'exclusiveMinimum', 'items', 'if', 'minItems', 'minimum', 'maxItems', 'maximum', 'multipleOf', 'not', 'oneOf', 'pattern', 'patternProperties', 'properties', 'required', 'then', 'type', 'typeSize', 'unevaluatedProperties', 'uniqueItems']
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/mt6359.yaml: ignoring, error in schema: properties: LDO_VAUD18-supply
warning: no schema found in file: ./Documentation/devicetree/bindings/sound/mt6359.yaml
See https://patchwork.ozlabs.org/patch/1396618
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-11-09 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 9:30 [PATCH v2 0/2] Fix vaud18 power leakage of mt6359 Shane Chien
2020-11-09 9:30 ` [PATCH v2 1/2] ASoC: " Shane Chien
2020-11-09 9:30 ` [PATCH v2 2/2] dt-bindings: mediatek: mt6359: Add new property for mt6359 Shane Chien
2020-11-09 15:43 ` Rob Herring [this message]
2020-11-10 16:02 ` [PATCH v2 0/2] Fix vaud18 power leakage of mt6359 Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201109154330.GA1343292@bogus \
--to=robh@kernel.org \
--cc=broonie@kernel.org \
--cc=chipeng.chang@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=jiaxin.yu@mediatek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shane.chien@mediatek.com \
--cc=wsd_upstream@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).