From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8C74C56201 for ; Wed, 11 Nov 2020 09:16:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D6EA206FB for ; Wed, 11 Nov 2020 09:16:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726636AbgKKJQl (ORCPT ); Wed, 11 Nov 2020 04:16:41 -0500 Received: from mail-ej1-f67.google.com ([209.85.218.67]:36993 "EHLO mail-ej1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726843AbgKKJQf (ORCPT ); Wed, 11 Nov 2020 04:16:35 -0500 Received: by mail-ej1-f67.google.com with SMTP id f20so1784437ejz.4; Wed, 11 Nov 2020 01:16:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=5GcEmhwwM9IRtfJDyYsg4AcdXZ2r4D6ZuT6XDfsXG3U=; b=uhVIjLeSDfdQ0fMQ050R9E7mC1gLN30tzzbMbzceHbJ5JuErY2DL9VMulwhEHsSS4M 5DX3rp0X+WBRjGejgwTB0kwfJP3tsTa+kkKTqiZWsIKuagLfTxZj4AlDURx/tjRN7X8k VWjm+fwGViTi+p37rQdvWYcUDxYfX5bI6tZ+z0Q6H6QgPeWiIGlJ44KKuZh2w03Xag+l KAD67kOuDstQjFmFJwrrVqTgjCKyVDpCgdMGbk1fe3aTqQgeyW1FgHiNpSnLl7xMHCMx bduG/gh4kiTEQY0KylL0a+SdN52m1QQL94+PyQhg9Wzb+83VNiVrHnWy6GkdkoqCGZV9 /ddQ== X-Gm-Message-State: AOAM531CSilfWTEXn/uTC2NCjlrdZ8jFp3vcfLOttms35w0j61a27Rk8 qvf8SCuJwPVuRii3g5WUQls= X-Google-Smtp-Source: ABdhPJwnk3jD93uxeY/uvOhBZvJMTv9+ToMcbWATfaaN/gyNNy295JDWNoeMCMqf8CBghVZn1l5k+Q== X-Received: by 2002:a17:906:7a11:: with SMTP id d17mr20705465ejo.153.1605086190784; Wed, 11 Nov 2020 01:16:30 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id nd5sm597535ejb.37.2020.11.11.01.16.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 01:16:29 -0800 (PST) Date: Wed, 11 Nov 2020 10:16:28 +0100 From: Krzysztof Kozlowski To: Serge Semin Cc: Mathias Nyman , Felipe Balbi , Greg Kroah-Hartman , Rob Herring , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Andy Gross , Bjorn Andersson , Manu Gautam , Roger Quadros , Lad Prabhakar , Yoshihiro Shimoda , Neil Armstrong , Kevin Hilman , Martin Blumenstingl , Chunfeng Yun , linux-arm-kernel@lists.infradead.org, linux-snps-arc@lists.infradead.org, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 10/18] dt-bindings: usb: Convert DWC USB3 bindings to DT schema Message-ID: <20201111091628.GC4050@kozik-lap> References: <20201111090853.14112-1-Sergey.Semin@baikalelectronics.ru> <20201111090853.14112-11-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201111090853.14112-11-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Nov 11, 2020 at 12:08:45PM +0300, Serge Semin wrote: > DWC USB3 DT node is supposed to be compliant with the Generic xHCI > Controller schema, but with additional vendor-specific properties, the > controller-specific reference clocks and PHYs. So let's convert the > currently available legacy text-based DWC USB3 bindings to the DT schema > and make sure the DWC USB3 nodes are also validated against the > usb-xhci.yaml schema. > > Note we have to discard the nodename restriction of being prefixed with > "dwc3@" string, since in accordance with the usb-hcd.yaml schema USB nodes > are supposed to be named as "^usb(@.*)". > > Signed-off-by: Serge Semin > > --- > > Changelog v2: > - Discard '|' from the descriptions, since we don't need to preserve > the text formatting in any of them. > - Drop quotes from around the string constants. > - Fix the "clock-names" prop description to be referring the enumerated > clock-names instead of the ones from the Databook. > > Changelog v3: > - Apply usb-xhci.yaml# schema only if the controller is supposed to work > as either host or otg. > > Changelog v4: > - Apply usb-drd.yaml schema first. If the controller is configured > to work in a gadget mode only, then apply the usb.yaml schema too, > otherwise apply the usb-xhci.yaml schema. > - Discard the Rob'es Reviewed-by tag. Please review the patch one more > time. > --- > .../devicetree/bindings/usb/dwc3.txt | 125 -------- > .../devicetree/bindings/usb/snps,dwc3.yaml | 303 ++++++++++++++++++ > 2 files changed, 303 insertions(+), 125 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/usb/dwc3.txt > create mode 100644 Documentation/devicetree/bindings/usb/snps,dwc3.yaml > > diff --git a/Documentation/devicetree/bindings/usb/dwc3.txt b/Documentation/devicetree/bindings/usb/dwc3.txt > deleted file mode 100644 > index d03edf9d3935..000000000000 > --- a/Documentation/devicetree/bindings/usb/dwc3.txt > +++ /dev/null > @@ -1,125 +0,0 @@ > -synopsys DWC3 CORE > - > -DWC3- USB3 CONTROLLER. Complies to the generic USB binding properties > - as described in 'usb/generic.txt' > - > -Required properties: > - - compatible: must be "snps,dwc3" > - - reg : Address and length of the register set for the device > - - interrupts: Interrupts used by the dwc3 controller. > - - clock-names: list of clock names. Ideally should be "ref", > - "bus_early", "suspend" but may be less or more. > - - clocks: list of phandle and clock specifier pairs corresponding to > - entries in the clock-names property. > - > -Exception for clocks: > - clocks are optional if the parent node (i.e. glue-layer) is compatible to > - one of the following: > - "cavium,octeon-7130-usb-uctl" > - "qcom,dwc3" > - "samsung,exynos5250-dwusb3" > - "samsung,exynos5433-dwusb3" > - "samsung,exynos7-dwusb3" > - "sprd,sc9860-dwc3" > - "st,stih407-dwc3" > - "ti,am437x-dwc3" > - "ti,dwc3" > - "ti,keystone-dwc3" > - "rockchip,rk3399-dwc3" > - "xlnx,zynqmp-dwc3" What happened with this part of dtschema? It sees you removed it. Best regards, Krzysztof