From: Lee Jones <lee.jones@linaro.org>
To: Gene Chen <gene.chen.richtek@gmail.com>
Cc: sre@kernel.org, matthias.bgg@gmail.com, robh+dt@kernel.org,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
gene_chen@richtek.com, Wilma.Wu@mediatek.com,
shufan_lee@richtek.com, cy_huang@richtek.com,
benjamin.chao@mediatek.com
Subject: Re: [PATCH v6 11/11] mfd: mt6360: Remove MT6360 regulator of_compatible attribute
Date: Wed, 11 Nov 2020 16:47:14 +0000 [thread overview]
Message-ID: <20201111164714.GR2063125@dell> (raw)
In-Reply-To: <1604656432-10215-12-git-send-email-gene.chen.richtek@gmail.com>
On Fri, 06 Nov 2020, Gene Chen wrote:
> From: Gene Chen <gene_chen@richtek.com>
>
> Remove MT6360 regulator of_compatible attribute because
> MFD device should just instantiate the platform device.
>
> Signed-off-by: Gene Chen <gene_chen@richtek.com>
> ---
> drivers/mfd/mt6360-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
> index 4bcfa7f..539ab43 100644
> --- a/drivers/mfd/mt6360-core.c
> +++ b/drivers/mfd/mt6360-core.c
> @@ -340,7 +340,7 @@ static const struct mfd_cell mt6360_devs[] = {
> OF_MFD_CELL("mt6360-led", mt6360_led_resources,
> NULL, 0, 0, "mediatek,mt6360-led"),
> OF_MFD_CELL("mt6360-regulator", mt6360_regulator_resources,
> - NULL, 0, 0, "mediatek,mt6360-regulator"),
> + NULL, 0, 0, NULL),
If you're no longer providing an OF compatible, you should use one of
the simper helpers.
> OF_MFD_CELL("mt6360-tcpc", NULL,
> NULL, 0, 0, "mediatek,mt6360-tcpc"),
> };
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2020-11-11 16:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-06 9:53 [PATCH v6 0/11] mfd: mt6360: Merge different sub-devices I2C read/write Gene Chen
2020-11-06 9:53 ` [PATCH v6 01/11] mfd: mt6360: Rearrange include file Gene Chen
2020-11-06 9:53 ` [PATCH v6 02/11] mfd: mt6360: Remove redundant brackets around raw numbers Gene Chen
2020-11-06 9:53 ` [PATCH v6 03/11] mfd: mt6360: Indicate sub-dev compatible name by using "-" Gene Chen
2020-11-06 9:53 ` [PATCH v6 04/11] mfd: mt6360: Combine mt6360 pmic/ldo resources into mt6360 regulator resources Gene Chen
2020-11-06 9:53 ` [PATCH v6 05/11] mfd: mt6360: Rename mt6360_pmu_data by mt6360_ddata Gene Chen
2020-11-06 9:53 ` [PATCH v6 06/11] mfd: mt6360: Rename mt6360_pmu by mt6360 Gene Chen
2020-11-06 9:53 ` [PATCH v6 07/11] mfd: mt6360: Remove handle_post_irq callback function Gene Chen
2020-11-06 9:53 ` [PATCH v6 08/11] mfd: mt6360: Fix flow which is used to check ic exist Gene Chen
2020-11-06 9:53 ` [PATCH v6 09/11] mfd: mt6360: Merge header file into driver and remove unuse register define Gene Chen
2020-11-06 9:53 ` [PATCH v6 10/11] mfd: mt6360: Merge different sub-devices I2C read/write Gene Chen
2020-11-11 16:45 ` Lee Jones
2020-11-06 9:53 ` [PATCH v6 11/11] mfd: mt6360: Remove MT6360 regulator of_compatible attribute Gene Chen
2020-11-11 16:47 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111164714.GR2063125@dell \
--to=lee.jones@linaro.org \
--cc=Wilma.Wu@mediatek.com \
--cc=benjamin.chao@mediatek.com \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=gene.chen.richtek@gmail.com \
--cc=gene_chen@richtek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=robh+dt@kernel.org \
--cc=shufan_lee@richtek.com \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).