From: Rob Herring <robh@kernel.org>
To: Eugen Hristev <eugen.hristev@microchip.com>
Cc: sakari.ailus@iki.fi, devicetree@vger.kernel.org,
jacopo@jmondi.org, laurent.pinchart@ideasonboard.com,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
robh+dt@kernel.org
Subject: Re: [PATCH v4 1/3] dt-bindings: media: atmel: csi2dc: add bindings for microchip csi2dc
Date: Wed, 11 Nov 2020 13:07:57 -0600 [thread overview]
Message-ID: <20201111190757.GB1844086@bogus> (raw)
In-Reply-To: <20201110151116.161260-1-eugen.hristev@microchip.com>
On Tue, 10 Nov 2020 17:11:14 +0200, Eugen Hristev wrote:
> Add bindings documentation for Microchip CSI2 Demultiplexer controller.
>
> CSI2DC is a demultiplexer from Synopsys IDI interface specification to
> parallel interface connection or direct memory access.
>
> Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>
> ---
> Changes in v4:
> - Removed property for inter-line-delay and for clock continuous/non-continuous
> - Removed virtual channel by reg for second endpoint
>
> Changes in v3:
> - Removed some text from description, as it was explained in the schema
> - fixed other things as per Rob's review
> - moved some text inside the schema, like the clock description
>
> Changes in v2:
> - fixed warnings reported by dt_binding_check
>
> .../bindings/media/microchip,csi2dc.yaml | 144 ++++++++++++++++++
> 1 file changed, 144 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/media/microchip,csi2dc.yaml
>
My bot found errors running 'make dt_binding_check' on your patch:
yamllint warnings/errors:
dtschema/dtc warnings/errors:
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/microchip,csi2dc.yaml: 'additionalProperties' is a required property
/builds/robherring/linux-dt-review/Documentation/devicetree/bindings/media/microchip,csi2dc.yaml: ignoring, error in schema:
warning: no schema found in file: ./Documentation/devicetree/bindings/media/microchip,csi2dc.yaml
See https://patchwork.ozlabs.org/patch/1397687
The base for the patch is generally the last rc1. Any dependencies
should be noted.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit.
next prev parent reply other threads:[~2020-11-11 19:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-10 15:11 [PATCH v4 1/3] dt-bindings: media: atmel: csi2dc: add bindings for microchip csi2dc Eugen Hristev
2020-11-10 15:11 ` [PATCH v4 2/3] media: atmel: introduce microchip csi2dc driver Eugen Hristev
2020-11-10 15:11 ` [PATCH v4 3/3] MAINTAINERS: add microchip csi2dc Eugen Hristev
2020-11-11 19:07 ` Rob Herring [this message]
2020-11-11 19:15 ` [PATCH v4 1/3] dt-bindings: media: atmel: csi2dc: add bindings for " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111190757.GB1844086@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=eugen.hristev@microchip.com \
--cc=jacopo@jmondi.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).