From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2719FC56201 for ; Wed, 11 Nov 2020 19:16:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BC680206B6 for ; Wed, 11 Nov 2020 19:16:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726134AbgKKTQo (ORCPT ); Wed, 11 Nov 2020 14:16:44 -0500 Received: from mail-oi1-f195.google.com ([209.85.167.195]:34312 "EHLO mail-oi1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725949AbgKKTQo (ORCPT ); Wed, 11 Nov 2020 14:16:44 -0500 Received: by mail-oi1-f195.google.com with SMTP id w188so3437779oib.1; Wed, 11 Nov 2020 11:16:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AiCDPZgcTf3GX/z2zx/26J8ErQhTL1mnCpMM32GGzw4=; b=RZqOV73fg83NnARBzEpikXdRWXZ/wpb77UjsNn7kiEtgNlrU72pYSjCqtSRUmdAVBa a062ntipt+6YkBYJscMKdraZL/2QtARcH31Oj2RKPHR1l/5icptYdNxgHF4b61Ng86/v 7V3ybWR/P7KBr83nJyjPdNWq4jInP66U6PJph7NA9jmWP6Dg16m419fnlm3uJ5SRr792 5rN3wgKdiBHd43r1xMVPMC6YowzJ6N0RJDcypR499Byy0riqb04DyXK7NlvG7EBJJNFw UPZswTwLswilZv8FPRlkKmMrQ34mHe0ivwtAl+36gDl0iLgBnCBSE2ezJjxxsOEH0OCE 1sWA== X-Gm-Message-State: AOAM533Y1IqhgA1PZPg3yZZh0+gnj8FW9X7/UzCewJvT2NkuKgbzkcT6 KGr+49wQ+nkW5TTDSfuPrBN7G1hHdQ== X-Google-Smtp-Source: ABdhPJwyi016mtmjmTLTqVQpJJDCJFBGadh4UUgCNqobL85eUP5paFNnEC8U07pacXIsSPdIILspgQ== X-Received: by 2002:aca:72ca:: with SMTP id p193mr3299201oic.9.1605122202551; Wed, 11 Nov 2020 11:16:42 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id n81sm588991oif.53.2020.11.11.11.16.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 11:16:41 -0800 (PST) Received: (nullmailer pid 1857962 invoked by uid 1000); Wed, 11 Nov 2020 19:16:40 -0000 Date: Wed, 11 Nov 2020 13:16:40 -0600 From: Rob Herring To: Serge Semin Cc: Martin Blumenstingl , devicetree@vger.kernel.org, Serge Semin , linux-mips@vger.kernel.org, Mathias Nyman , linux-arm-kernel@lists.infradead.org, Pavel Parkhomenko , Manu Gautam , Roger Quadros , linux-snps-arc@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, Greg Kroah-Hartman , Yoshihiro Shimoda , Rob Herring , Neil Armstrong , Krzysztof Kozlowski , Chunfeng Yun , Alexey Malahov , linux-kernel@vger.kernel.org, Andy Gross , Felipe Balbi , Lad Prabhakar , Kevin Hilman , linux-usb@vger.kernel.org, Bjorn Andersson Subject: Re: [PATCH v4 01/18] dt-bindings: usb: usb-hcd: Detach generic USB controller properties Message-ID: <20201111191640.GA1857205@bogus> References: <20201111090853.14112-1-Sergey.Semin@baikalelectronics.ru> <20201111090853.14112-2-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201111090853.14112-2-Sergey.Semin@baikalelectronics.ru> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, 11 Nov 2020 12:08:36 +0300, Serge Semin wrote: > There can be three distinctive types of the USB controllers: USB hosts, > USB peripherals/gadgets and USB OTG, which can switch from one role to > another. In order to have that hierarchy handled in the DT binding files, > we need to collect common properties in a common DT schema and specific > properties in dedicated schemas. Seeing the usb-hcd.yaml DT schema is > dedicated for the USB host controllers only, let's move some common > properties from there into the usb.yaml schema. So the later would be > available to evaluate all currently supported types of the USB > controllers. > > While at it add an explicit "additionalProperties: true" into the > usb-hcd.yaml as setting the additionalProperties/unevaluateProperties > properties is going to be get mandatory soon. > > Signed-off-by: Serge Semin > > --- > > Changelog v4: > - This is a new patch created as a result of the comment left > by Chunfeng Yun in v3 > --- > .../devicetree/bindings/usb/usb-hcd.yaml | 14 ++------- > .../devicetree/bindings/usb/usb.yaml | 29 +++++++++++++++++++ > 2 files changed, 32 insertions(+), 11 deletions(-) > create mode 100644 Documentation/devicetree/bindings/usb/usb.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: ./Documentation/devicetree/bindings/usb/usb-hcd.yaml:17:1: [error] duplication of key "additionalProperties" in mapping (key-duplicates) dtschema/dtc warnings/errors: Traceback (most recent call last): File "/usr/local/bin/dt-extract-example", line 45, in binding = yaml.load(open(args.yamlfile, encoding='utf-8').read()) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/main.py", line 343, in load return constructor.get_single_data() File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 113, in get_single_data return self.construct_document(node) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 123, in construct_document for _dummy in generator: File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 723, in construct_yaml_map value = self.construct_mapping(node) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 440, in construct_mapping return BaseConstructor.construct_mapping(self, node, deep=deep) File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 257, in construct_mapping if self.check_mapping_key(node, key_node, mapping, key, value): File "/usr/local/lib/python3.8/dist-packages/ruamel/yaml/constructor.py", line 295, in check_mapping_key raise DuplicateKeyError(*args) ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping in "", line 4, column 1 found duplicate key "additionalProperties" with value "True" (original value: "True") in "", line 17, column 1 To suppress this check see: http://yaml.readthedocs.io/en/latest/api.html#duplicate-keys Duplicate keys will become an error in future releases, and are errors by default when using the new API. make[1]: *** [Documentation/devicetree/bindings/Makefile:20: Documentation/devicetree/bindings/usb/usb-hcd.example.dts] Error 1 make[1]: *** Deleting file 'Documentation/devicetree/bindings/usb/usb-hcd.example.dts' make[1]: *** Waiting for unfinished jobs.... make[1]: *** [Documentation/devicetree/bindings/Makefile:59: Documentation/devicetree/bindings/processed-schema-examples.json] Error 123 make: *** [Makefile:1364: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1398034 The base for the patch is generally the last rc1. Any dependencies should be noted. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.