From: Rob Herring <robh@kernel.org>
To: Daniel Palmer <daniel@0x0f.com>
Cc: maz@kernel.org, linux-kernel@vger.kernel.org,
linus.walleij@linaro.org, soc@kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
w@1wt.eu, linux-gpio@vger.kernel.org
Subject: Re: [PATCH v3 1/5] dt-bindings: gpio: Add a binding header for the MSC313 GPIO driver
Date: Wed, 11 Nov 2020 14:28:47 -0600 [thread overview]
Message-ID: <20201111202847.GA1974400@bogus> (raw)
In-Reply-To: <20201109121731.1537580-2-daniel@0x0f.com>
On Mon, 09 Nov 2020 21:17:27 +0900, Daniel Palmer wrote:
> Header adds defines for the gpio number of each pad from the driver view.
>
> The gpio block seems to have enough registers for 128 lines but what line
> is mapped to a physical pin depends on the chip. The gpio block also seems
> to contain some registers that are not related to gpio but needed somewhere
> to go.
>
> Because of the above the driver itself uses the index of a pin's offset in
> an array of the possible offsets for a chip as the gpio number.
>
> Signed-off-by: Daniel Palmer <daniel@0x0f.com>
> ---
> MAINTAINERS | 1 +
> include/dt-bindings/gpio/msc313-gpio.h | 53 ++++++++++++++++++++++++++
> 2 files changed, 54 insertions(+)
> create mode 100644 include/dt-bindings/gpio/msc313-gpio.h
>
Reviewed-by: Rob Herring <robh@kernel.org>
next prev parent reply other threads:[~2020-11-11 20:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-09 12:17 [PATCH v3 0/5] Add GPIO support for MStar/SigmaStar ARMv7 Daniel Palmer
2020-11-09 12:17 ` [PATCH v3 1/5] dt-bindings: gpio: Add a binding header for the MSC313 GPIO driver Daniel Palmer
2020-11-11 20:28 ` Rob Herring [this message]
2020-11-09 12:17 ` [PATCH v3 2/5] dt-bindings: gpio: Binding for MStar MSC313 GPIO controller Daniel Palmer
2020-11-11 21:06 ` Rob Herring
2020-11-12 10:57 ` Daniel Palmer
2020-11-09 12:17 ` [PATCH v3 3/5] gpio: msc313: MStar MSC313 GPIO driver Daniel Palmer
2020-11-09 12:17 ` [PATCH v3 4/5] ARM: mstar: Add gpio controller to MStar base dtsi Daniel Palmer
2020-11-09 12:17 ` [PATCH v3 5/5] ARM: mstar: Fill in GPIO controller properties for infinity Daniel Palmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111202847.GA1974400@bogus \
--to=robh@kernel.org \
--cc=daniel@0x0f.com \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=soc@kernel.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).