From: Thierry Reding <thierry.reding@gmail.com>
To: "Rahul Tanwar" <rahul.tanwar@linux.intel.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-pwm@vger.kernel.org, lee.jones@linaro.org,
p.zabel@pengutronix.de, robh+dt@kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
andriy.shevchenko@intel.com, songjun.Wu@intel.com,
cheol.yong.kim@intel.com, qi-ming.wu@intel.com,
rahul.tanwar.linux@gmail.com
Subject: Re: [PATCH v15 0/2] pwm: intel: Add PWM driver for a new SoC
Date: Wed, 11 Nov 2020 21:40:43 +0100 [thread overview]
Message-ID: <20201111204043.GO6125@ulmo> (raw)
In-Reply-To: <cover.1604555266.git.rahul.tanwar@linux.intel.com>
[-- Attachment #1: Type: text/plain, Size: 993 bytes --]
On Thu, Nov 05, 2020 at 01:49:38PM +0800, Rahul Tanwar wrote:
> Patch 1 adds dt binding document in YAML format.
> Patch 2 add PWM fan controller driver for LGM SoC.
>
> v15:
> - Rebase to latest linux 5.10-rc2
>
> v14:
> - Address below review concerns from Uwe Kleine-K?nig.
> * Add limitations info about fixed 2-wire mode support.
> * Rename clk/reset _disable function names to _release.
> * Remove clk & rst from driver data structure. Instead
> use them as arguments.
> * Add pwm_chip.base = -1.
> - Resolve missing MODULE_LICENSE warning.
>
> v13:
> - Address below review concerns (Philipp Zabel)
> * Make unnecessary 2 line comment as 1 line comment.
> * Move reset_deassert at the last after clk_enable.
> * Remove unnecessary return ret statement from .remove()
> - Move platform_set_drvdata() at the top of probe.
Uwe,
you had concerns about v13 of this. Can you take a look if all your
comments have been addressed?
Thanks,
Thierry
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-11-11 20:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-05 5:49 [PATCH v15 0/2] pwm: intel: Add PWM driver for a new SoC Rahul Tanwar
2020-11-05 5:49 ` [PATCH v15 1/2] Add DT bindings YAML schema for PWM fan controller of LGM SoC Rahul Tanwar
2020-11-05 5:49 ` [PATCH v15 2/2] Add PWM fan controller driver for " Rahul Tanwar
2020-11-11 21:01 ` Uwe Kleine-König
2020-11-11 20:40 ` Thierry Reding [this message]
2020-11-11 21:14 ` [PATCH v15 0/2] pwm: intel: Add PWM driver for a new SoC Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201111204043.GO6125@ulmo \
--to=thierry.reding@gmail.com \
--cc=andriy.shevchenko@intel.com \
--cc=cheol.yong.kim@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=qi-ming.wu@intel.com \
--cc=rahul.tanwar.linux@gmail.com \
--cc=rahul.tanwar@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=songjun.Wu@intel.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).