Re: [PATCH 1/2] dt-bindings: reset: document Broadcom's PMC binding

[Rob Herring <robh@kernel.org>]

On Mon, Nov 09, 2020 at 05:35:18PM +0100, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
> 
> Broadcom's PMC is Power Management Controller that is used for disabling
> and enabling SoC devices.
> 
> Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
> ---
>  .../bindings/reset/brcm,bcm-pmc.yaml          | 69 +++++++++++++++++++
>  1 file changed, 69 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/reset/brcm,bcm-pmc.yaml
> 
> diff --git a/Documentation/devicetree/bindings/reset/brcm,bcm-pmc.yaml b/Documentation/devicetree/bindings/reset/brcm,bcm-pmc.yaml
> new file mode 100644
> index 000000000000..2afc2048997f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/reset/brcm,bcm-pmc.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/reset/brcm,bcm-pmc.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Broadcom PMC (Power Management Controller) reset controller
> +
> +description: This document describes the Broadcom's PMC (Power Management
> +  Controller). It supports resetting devices identified by the bus id and device
> +  address.
> +
> +maintainers:
> +  - Rafał Miłecki <rafal@milecki.pl>
> +
> +properties:
> +  compatible:
> +    enum:
> +      - brcm,bcm4908-pmc # PMC on BCM4908 and compatible SoCs
> +
> +  reg:
> +    maxItems: 1
> +
> +  syscon-misc:

Needs a vendor prefix

> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Phandle to the MISC system controller node.
> +
> +  syscon-procmon:

Needs a vendor prefix

> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description:
> +      Phandle to the PROC MON system controller node.
> +
> +  big-endian:
> +    $ref: /schemas/types.yaml#/definitions/flag
> +    description:
> +      Flag to use for block working in big endian mode.
> +
> +  "#reset-cells":
> +    const: 2
> +
> +required:
> +  - compatible
> +  - reg
> +  - syscon-misc
> +  - syscon-procmon
> +  - "#reset-cells"
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    pmc: reset-controller@80200000 {
> +        compatible = "brcm,bcm4908-pmc";
> +        reg = <0x80200000 0x5000>;
> +        syscon-misc = <&misc>;
> +        syscon-procmon = <&procmon>;
> +        #reset-cells = <2>;
> +    };
> +
> +    procmon: syscon@80280000 {
> +        compatible = "brcm,misc", "syscon";

IIRC, not a documented compatible. Nor is it specific enough.

You can just drop these from the example.

> +        reg = <0x80280000 0x1000>;
> +    };
> +
> +    misc: syscon@ff802600 {
> +        compatible = "brcm,misc", "syscon";
> +        reg = <0xff802600 0xe4>;
> +    };
> -- 
> 2.27.0
>