From: Krzysztof Kozlowski <krzk@kernel.org>
To: Alice Guo <alice.guo@nxp.com>
Cc: robh+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de,
linux-imx@nxp.com, peng.fan@nxp.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 3/4] arm64: dts: imx8m: add nvmem-cell related stuff
Date: Sat, 14 Nov 2020 17:00:52 +0100 [thread overview]
Message-ID: <20201114160052.GC14989@kozik-lap> (raw)
In-Reply-To: <20201113110409.13546-3-alice.guo@nxp.com>
On Fri, Nov 13, 2020 at 07:04:08PM +0800, Alice Guo wrote:
> Add nvmem-cell related stuff for the soc unique ID.
Do not silently ignore comments during review. Let me repeat my comment
from v1:
Subject and commit msg: please do not add "stuff" but describe what
are you adding and why (what is the purpose, feature, benefit).
"Stuff" is too generic.
I can rephrase it, since maybe I was not understood. Do not use words
like "stuff" or "thing". Instead describe exactly what you are adding
and answer to the most important question: why are you adding it.
Best regards,
Krzysztof
>
> Signed-off-by: Alice Guo <alice.guo@nxp.com>
> ---
> arch/arm64/boot/dts/freescale/imx8mm.dtsi | 6 ++++++
> arch/arm64/boot/dts/freescale/imx8mn.dtsi | 6 ++++++
> arch/arm64/boot/dts/freescale/imx8mp.dtsi | 6 ++++++
> arch/arm64/boot/dts/freescale/imx8mq.dtsi | 6 ++++++
> 4 files changed, 24 insertions(+)
next prev parent reply other threads:[~2020-11-14 16:00 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 11:04 [PATCH v3 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Alice Guo
2020-11-13 11:04 ` [PATCH v3 2/4] arm64: dts: imx8m: add compatible string to .dtsi file Alice Guo
2020-11-14 15:57 ` Krzysztof Kozlowski
2020-11-16 7:12 ` [EXT] " Alice Guo
2020-11-13 11:04 ` [PATCH v3 3/4] arm64: dts: imx8m: add nvmem-cell related stuff Alice Guo
2020-11-14 16:00 ` Krzysztof Kozlowski [this message]
2020-11-16 7:16 ` [EXT] " Alice Guo
2020-11-13 11:04 ` [PATCH v3 4/4] soc: imx8m: change to use platform driver Alice Guo
2020-11-14 16:41 ` Krzysztof Kozlowski
2020-11-16 8:18 ` [EXT] " Alice Guo
2020-11-16 16:13 ` Krzysztof Kozlowski
2020-11-18 10:28 ` Alice Guo
2020-11-18 10:42 ` Krzysztof Kozlowski
2020-11-18 14:07 ` Alice Guo
2020-11-18 14:10 ` Krzysztof Kozlowski
2020-11-19 7:32 ` Alice Guo
2020-11-19 9:42 ` Krzysztof Kozlowski
2020-11-14 15:55 ` [PATCH v3 1/4] dt-bindings: soc: imx8m: add DT Binding doc for soc unique ID Krzysztof Kozlowski
2020-11-14 16:49 ` Krzysztof Kozlowski
2020-11-16 7:04 ` [EXT] " Alice Guo
2020-11-16 16:03 ` Krzysztof Kozlowski
2020-11-17 7:12 ` Alice Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201114160052.GC14989@kozik-lap \
--to=krzk@kernel.org \
--cc=alice.guo@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).