devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Marek Behún" <kabel@kernel.org>
To: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: arm@kernel.org, "Marek Behún" <kabel@kernel.org>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Jason Cooper" <jason@lakedaemon.net>,
	"Andreas Färber" <afaerber@suse.de>,
	"Rob Herring" <robh+dt@kernel.org>,
	devicetree@vger.kernel.org
Subject: [PATCH mvebu-dt v2 6/6] ARM: dts: turris-omnia: update ethernet-phy node and handle name
Date: Sat, 14 Nov 2020 19:32:17 +0100	[thread overview]
Message-ID: <20201114183217.1352-7-kabel@kernel.org> (raw)
In-Reply-To: <20201114183217.1352-1-kabel@kernel.org>

Use property name `phy-handle` instead of the deprecated `phy` to
connect eth2 to the PHY.
Rename the node from "phy@1" to "ethernet-phy@1", since "phy@1" is
incorrect according to device-tree bindings documentation.
Also remove the "ethernet-phy-id0141.0DD1" compatible string, it is not
needed. Kernel can read the PHY identifier itself.

Signed-off-by: Marek Behún <kabel@kernel.org>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Cc: Uwe Kleine-König <uwe@kleine-koenig.org>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Gregory CLEMENT <gregory.clement@bootlin.com>
Cc: Andreas Färber <afaerber@suse.de>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: devicetree@vger.kernel.org
---
 arch/arm/boot/dts/armada-385-turris-omnia.dts | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/arch/arm/boot/dts/armada-385-turris-omnia.dts b/arch/arm/boot/dts/armada-385-turris-omnia.dts
index df53cf925db6..694d69798685 100644
--- a/arch/arm/boot/dts/armada-385-turris-omnia.dts
+++ b/arch/arm/boot/dts/armada-385-turris-omnia.dts
@@ -145,7 +145,7 @@ fixed-link {
 &eth2 {
 	status = "okay";
 	phy-mode = "sgmii";
-	phy = <&phy1>;
+	phy-handle = <&phy1>;
 	phys = <&comphy5 2>;
 	sfp = <&sfp>;
 	buffer-manager = <&bm>;
@@ -374,9 +374,9 @@ &mdio {
 	pinctrl-0 = <&mdio_pins>;
 	status = "okay";
 
-	phy1: phy@1 {
+	phy1: ethernet-phy@1 {
 		status = "okay";
-		compatible = "ethernet-phy-id0141.0DD1", "ethernet-phy-ieee802.3-c22";
+		compatible = "ethernet-phy-ieee802.3-c22";
 		reg = <1>;
 
 		/* irq is connected to &pcawan pin 7 */
-- 
2.26.2


  parent reply	other threads:[~2020-11-14 18:32 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-14 18:32 [PATCH mvebu-dt v2 0/6] Turris Omnia device-tree changes Marek Behún
2020-11-14 18:32 ` [PATCH mvebu-dt v2 1/6] ARM: dts: turris-omnia: enable HW buffer management Marek Behún
2020-11-14 18:32 ` [PATCH mvebu-dt v2 2/6] ARM: dts: turris-omnia: add comphy handle to eth2 Marek Behún
2020-11-14 21:25   ` Andreas Färber
2020-11-14 18:32 ` [PATCH mvebu-dt v2 3/6] ARM: dts: turris-omnia: describe switch interrupt Marek Behún
2020-11-14 18:32 ` [PATCH mvebu-dt v2 4/6] ARM: dts: turris-omnia: add SFP node Marek Behún
2020-11-14 21:36   ` Andreas Färber
2020-11-14 21:42     ` Russell King - ARM Linux admin
2020-11-14 21:46       ` Andreas Färber
2020-11-14 22:55       ` Marek Behún
2020-11-15 11:28         ` Russell King - ARM Linux admin
2020-11-14 22:57     ` Marek Behún
2020-11-14 23:16       ` Andreas Färber
2020-11-15  0:32         ` Marek Behún
2020-11-15  0:38         ` Marek Behún
2020-11-14 23:27     ` Andreas Färber
2020-11-15  0:11       ` Marek Behún
2020-11-14 18:32 ` [PATCH mvebu-dt v2 5/6] ARM: dts: turris-omnia: add LED controller node Marek Behún
2020-11-14 21:58   ` Andreas Färber
2020-11-14 23:23     ` Marek Behún
2020-11-14 18:32 ` Marek Behún [this message]
2020-11-14 22:04   ` [PATCH mvebu-dt v2 6/6] ARM: dts: turris-omnia: update ethernet-phy node and handle name Andreas Färber
2020-11-14 23:30     ` Marek Behún

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201114183217.1352-7-kabel@kernel.org \
    --to=kabel@kernel.org \
    --cc=afaerber@suse.de \
    --cc=andrew@lunn.ch \
    --cc=arm@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=jason@lakedaemon.net \
    --cc=robh+dt@kernel.org \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).