From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 630B2C63697 for ; Sat, 14 Nov 2020 19:17:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 239D122265 for ; Sat, 14 Nov 2020 19:17:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726295AbgKNTQq (ORCPT ); Sat, 14 Nov 2020 14:16:46 -0500 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:39033 "EHLO relay9-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726239AbgKNTQq (ORCPT ); Sat, 14 Nov 2020 14:16:46 -0500 X-Greylist: delayed 78586 seconds by postgrey-1.27 at vger.kernel.org; Sat, 14 Nov 2020 14:16:45 EST X-Originating-IP: 86.194.74.19 Received: from localhost (lfbn-lyo-1-997-19.w86-194.abo.wanadoo.fr [86.194.74.19]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 60FE7FF805; Sat, 14 Nov 2020 19:16:43 +0000 (UTC) Date: Sat, 14 Nov 2020 20:16:42 +0100 From: Alexandre Belloni To: Jonathan Cameron Cc: Lars-Peter Clausen , Peter Meerwald-Stadler , Nicolas Ferre , Ludovic Desroches , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/9] iio: adc: at91_adc: rework trigger definition Message-ID: <20201114191642.GA5272@piout.net> References: <20201113212650.507680-1-alexandre.belloni@bootlin.com> <20201113212650.507680-5-alexandre.belloni@bootlin.com> <20201114170230.5a94a192@archlinux> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201114170230.5a94a192@archlinux> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 14/11/2020 17:02:30+0000, Jonathan Cameron wrote: > On Fri, 13 Nov 2020 22:26:45 +0100 > Alexandre Belloni wrote: > > > Move the available trigger definition back in the driver to stop cluttering > > the device tree. There is no functional change except that it actually > > fixes the available triggers for at91sam9rl as it inherited the list from > > at91sam9260 but actually has the triggers from at91sam9x5. > > Is that a fix we might want to backport? If not we should probably put a clear > statement in here to avoid it getting picked up by the bot. > > I'd argue it's to invasive a change to backport. > Nobody ever complained about it so I don't think it is necessary to backport. Anyway, the proper backportable fix would be to simply change the device tree, that avoids the driver change which I also think is too invasive. I'll include the DT change in v2.