From: "Martin Jücker" <martin.juecker@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-samsung-soc@vger.kernel.org, kgene@kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v3 2/5] ARM: dts: add Samsung's exynos4412-based p4note boards
Date: Sun, 15 Nov 2020 18:48:43 +0100 [thread overview]
Message-ID: <20201115174843.GA33100@adroid> (raw)
In-Reply-To: <20201115103251.GB4587@kozik-lap>
On Sun, Nov 15, 2020 at 11:32:51AM +0100, Krzysztof Kozlowski wrote:
> On Fri, Nov 13, 2020 at 10:25:23PM +0100, Martin Jücker wrote:
> > The p4note family contains a couple of variants of the Galaxy Note 10.1
> > tablet with mainly different modems. The GT-N8010/GT-N8013 is the wifi
> > only version.
> >
> > Signed-off-by: Martin Jücker <martin.juecker@gmail.com>
> > ---
> > arch/arm/boot/dts/Makefile | 1 +
> > arch/arm/boot/dts/exynos4412-p4note-n8010.dts | 17 +
> > arch/arm/boot/dts/exynos4412-p4note.dtsi | 1132 +++++++++++++++++
> > 3 files changed, 1150 insertions(+)
> > create mode 100644 arch/arm/boot/dts/exynos4412-p4note-n8010.dts
> > create mode 100644 arch/arm/boot/dts/exynos4412-p4note.dtsi
> >
> > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> > index ce66ffd5a1bb..55ffee2b20f8 100644
> > --- a/arch/arm/boot/dts/Makefile
> > +++ b/arch/arm/boot/dts/Makefile
> > @@ -197,6 +197,7 @@ dtb-$(CONFIG_ARCH_EXYNOS4) += \
> > exynos4412-odroidx.dtb \
> > exynos4412-odroidx2.dtb \
> > exynos4412-origen.dtb \
> > + exynos4412-p4note-n8010.dtb \
> > exynos4412-smdk4412.dtb \
> > exynos4412-tiny4412.dtb \
> > exynos4412-trats2.dtb
> > diff --git a/arch/arm/boot/dts/exynos4412-p4note-n8010.dts b/arch/arm/boot/dts/exynos4412-p4note-n8010.dts
> > new file mode 100644
> > index 000000000000..9f559425bd2c
> > --- /dev/null
> > +++ b/arch/arm/boot/dts/exynos4412-p4note-n8010.dts
> > @@ -0,0 +1,17 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Samsung's Galaxy Note 10.1 - N801x (wifi only version)
> > + *
> > + * Copyright (c) 2013 Samsung Electronics Co., Ltd.
> > + * http://www.samsung.com
>
> Here and in other files - why did you remove your copyright? My comment
> from previous version: "If it is true, then include the copyright of
> original work as well."
>
> Best regards,
> Krzysztof
>
Hey Krzysztof,
in the second response you wrote that "usually we keep the copyright of
original file", I understood this as only the Samsung header as it is
done for the midas, i930x and n710x. A lot of it is basically the same
but with changed gpios. I really don't need my copyright up there if
it's not strictly necessary.
Cheers
Martin
next prev parent reply other threads:[~2020-11-15 17:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-13 21:25 [PATCH v3 0/5] add exynos4412-based p4note device family support Martin Jücker
2020-11-13 21:25 ` [PATCH v3 1/5] dt-bindings: samsung: document bindings for p4note family boards Martin Jücker
2020-11-16 16:17 ` Krzysztof Kozlowski
2020-11-13 21:25 ` [PATCH v3 2/5] ARM: dts: add Samsung's exynos4412-based p4note boards Martin Jücker
2020-11-15 10:32 ` Krzysztof Kozlowski
2020-11-15 17:48 ` Martin Jücker [this message]
2020-11-15 21:22 ` Krzysztof Kozlowski
2020-11-16 16:18 ` Krzysztof Kozlowski
2020-11-13 21:25 ` [PATCH v3 3/5] ARM: defconfig: add stmpe adc driver for p4note Martin Jücker
2020-11-16 16:22 ` Krzysztof Kozlowski
2020-11-13 21:25 ` [PATCH v3 4/5] ARM: defconfig: compile Atmel MXT touchscreeen as module Martin Jücker
2020-11-16 16:23 ` Krzysztof Kozlowski
2020-11-13 21:25 ` [PATCH v3 5/5] ARM: exynos: extend cpuidle support to p4note boards Martin Jücker
2020-11-16 16:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201115174843.GA33100@adroid \
--to=martin.juecker@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=kgene@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).