From: Rob Herring <robh@kernel.org>
To: Wenbin Mei <wenbin.mei@mediatek.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
irq-linux@rere.qmqm.pl,
Veerabhadrarao Badiganti <vbadigan@codeaurora.org>,
Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
Baolin Wang <baolin.wang@linaro.org>,
Ludovic Barre <ludovic.barre@st.com>,
Krishna Konda <kkonda@codeaurora.org>,
Bradley Bolen <bradleybolen@gmail.com>,
Chaotian Jing <chaotian.jing@mediatek.com>,
linux-mmc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, srv_heupstream@mediatek.com
Subject: Re: [PATCH v1 1/3] dt-bindings: mmc: Add optional cqe off properties
Date: Mon, 16 Nov 2020 13:28:01 -0600 [thread overview]
Message-ID: <20201116192801.GA1991505@bogus> (raw)
In-Reply-To: <20201112075208.28183-2-wenbin.mei@mediatek.com>
On Thu, Nov 12, 2020 at 03:52:06PM +0800, Wenbin Mei wrote:
> Add optional properties for cqe hosts which are used to set cqe off
> during suspend flow.
>
> Signed-off-by: Wenbin Mei <wenbin.mei@mediatek.com>
> ---
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index b96da0c7f819..457c9a84b988 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -164,6 +164,13 @@ properties:
> description:
> enable SDIO IRQ signalling on this interface
>
> + cqe-off-in-suspend:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + After suspend, the mmc host is powered off by HW, and bring CQE register
> + to default state, so we add the flag to re-init CQE register after resume
> + back.
The driver change is before suspend, but this says on resume...
In any case, this should be implied by the SoC specific compatible.
> +
> full-pwr-cycle:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> --
> 2.18.0
>
next prev parent reply other threads:[~2020-11-16 19:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 7:52 [PATCH v1 0/3] Set cqe off during suspend flow Wenbin Mei
2020-11-12 7:52 ` [PATCH v1 1/3] dt-bindings: mmc: Add optional cqe off properties Wenbin Mei
2020-11-16 19:28 ` Rob Herring [this message]
2020-11-18 3:26 ` Wenbin Mei
2020-11-12 7:52 ` [PATCH v1 2/3] arm64: dts: mt8192: Add cqe off flag Wenbin Mei
2020-11-12 7:52 ` [PATCH v1 3/3] mmc: core: Set cqe off during suspend flow Wenbin Mei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201116192801.GA1991505@bogus \
--to=robh@kernel.org \
--cc=baolin.wang@linaro.org \
--cc=bradleybolen@gmail.com \
--cc=chaotian.jing@mediatek.com \
--cc=devicetree@vger.kernel.org \
--cc=irq-linux@rere.qmqm.pl \
--cc=kkonda@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=ludovic.barre@st.com \
--cc=matthias.bgg@gmail.com \
--cc=srv_heupstream@mediatek.com \
--cc=ulf.hansson@linaro.org \
--cc=vbadigan@codeaurora.org \
--cc=wenbin.mei@mediatek.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).