From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7734EC6369E for ; Wed, 18 Nov 2020 07:20:17 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1C59E2467A for ; Wed, 18 Nov 2020 07:20:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="U1GoIM1A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726810AbgKRHT4 (ORCPT ); Wed, 18 Nov 2020 02:19:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726524AbgKRHT4 (ORCPT ); Wed, 18 Nov 2020 02:19:56 -0500 Received: from mail-pg1-x544.google.com (mail-pg1-x544.google.com [IPv6:2607:f8b0:4864:20::544]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13443C061A4D for ; Tue, 17 Nov 2020 23:19:55 -0800 (PST) Received: by mail-pg1-x544.google.com with SMTP id t37so492214pga.7 for ; Tue, 17 Nov 2020 23:19:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ogAqzoWb6CN+6DA0U4kbAuwXiWSIUBjOQhukqqaTMWo=; b=U1GoIM1AdmuL58NN4XCeb2w7fxo0jF8vBuA/6z7kciUFM/PGFVLarqF/CD/rUGIBec zCSqu8XcBIH4CRT4geHYFcs41uy7Bgjl8lZAURJb12FYD1rOAZWfJxBd7tLOaMZSqWPb dw2Jxyk1mCon9uig7mYnxDhHOuLrjj+xNZXSYRLwO2ZIwGpBK0fExFQJ+eFhnRWmzbXl rmlplR88Zi8UDPDZ1E61nCx3kjmec1UWS+rzNYI41VEigLg2LAxg3LnqKn9VKhQBUMRC OYFMYYKm7LV71qkUKTr7vaxPjlEEeHrrpgQRK5KiDRdM6IFnwhQ5gg4VlyWGc9pCgW6Y RUyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ogAqzoWb6CN+6DA0U4kbAuwXiWSIUBjOQhukqqaTMWo=; b=VeefQhHB5S+uUEFrAviU5ycWBUCHy0+6f3ti13oY144ZAGxN9lV+tDIwHiyTHTx1Zx TYE96ryv/prlsI+5Dx2Ve5nTf7PFvdQ8lZkHCBLTt8IP7Aw+jdTr/NtO675z2r5Y+XxC p2ZTpby2ZCOiCUECa9q33UWknPjpcNf0xdla4Kg3fqNX9KBvPkCND3/OHdvSP72mcuKx YnPr7uldD69R9l+YxdPitSPmvfyNW98SpvV4/RMXIAMnusPVlU7VkbxX+vDUoFugHnY+ QMgdPifp+/gAnnsK2/0ADqJ/a23RZmgUSRV1jvuo8dyXTcgRIh8rcDkpDTC7dGlJboVc 6c6w== X-Gm-Message-State: AOAM5332rGBuWo92ges9BhvgTH5EThMZrW5kZ72w0BtgXaG8rn4q2nR7 ngobPZwekl0JtKtZAGAEFD6+ X-Google-Smtp-Source: ABdhPJzKPAtFVRCbCKxNDq+2mj9Roy24FWwpRwKrKmMA9dbc3IHJxH1l9zjkYhMbcHX0Q0fTfEv3mA== X-Received: by 2002:a62:7e14:0:b029:18a:d515:dc47 with SMTP id z20-20020a627e140000b029018ad515dc47mr3552810pfc.78.1605683994282; Tue, 17 Nov 2020 23:19:54 -0800 (PST) Received: from work ([103.59.133.81]) by smtp.gmail.com with ESMTPSA id q23sm23942973pfg.192.2020.11.17.23.19.51 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Nov 2020 23:19:53 -0800 (PST) Date: Wed, 18 Nov 2020 12:49:47 +0530 From: Manivannan Sadhasivam To: Bjorn Andersson Cc: miquel.raynal@bootlin.com, richard@nod.at, vigneshr@ti.com, robh+dt@kernel.org, linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/4] mtd: parsers: Add Qcom SMEM parser Message-ID: <20201118071947.GB3286@work> References: <20201117174845.28684-1-manivannan.sadhasivam@linaro.org> <20201117174845.28684-3-manivannan.sadhasivam@linaro.org> <20201118042033.GH8532@builder.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201118042033.GH8532@builder.lan> User-Agent: Mutt/1.9.4 (2018-02-28) Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Nov 17, 2020 at 10:20:33PM -0600, Bjorn Andersson wrote: > On Tue 17 Nov 11:48 CST 2020, Manivannan Sadhasivam wrote: > > > NAND based Qualcomm platforms have the partition table populated in the > > Shared Memory (SMEM). Hence, add a parser for parsing the partitions > > from it. > > > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/mtd/parsers/Kconfig | 8 ++ > > drivers/mtd/parsers/Makefile | 1 + > > drivers/mtd/parsers/qcomsmempart.c | 169 +++++++++++++++++++++++++++++ > > 3 files changed, 178 insertions(+) > > create mode 100644 drivers/mtd/parsers/qcomsmempart.c > > > > diff --git a/drivers/mtd/parsers/Kconfig b/drivers/mtd/parsers/Kconfig > > index e72354322f62..d90c30229052 100644 > > --- a/drivers/mtd/parsers/Kconfig > > +++ b/drivers/mtd/parsers/Kconfig > > @@ -160,3 +160,11 @@ config MTD_REDBOOT_PARTS_READONLY > > 'FIS directory' images, enable this option. > > > > endif # MTD_REDBOOT_PARTS > > + > > +config MTD_QCOMSMEM_PARTS > > + tristate "Qualcomm SMEM NAND flash partition parser" > > + depends on MTD_NAND_QCOM || COMPILE_TEST > > + depends on QCOM_SMEM > > + help > > + This provides support for parsing partitions from Shared Memory (SMEM) > > + for NAND flash on Qualcomm platforms. > > diff --git a/drivers/mtd/parsers/Makefile b/drivers/mtd/parsers/Makefile > > index b0c5f62f9e85..50eb0b0a2210 100644 > > --- a/drivers/mtd/parsers/Makefile > > +++ b/drivers/mtd/parsers/Makefile > > @@ -9,3 +9,4 @@ obj-$(CONFIG_MTD_AFS_PARTS) += afs.o > > obj-$(CONFIG_MTD_PARSER_TRX) += parser_trx.o > > obj-$(CONFIG_MTD_SHARPSL_PARTS) += sharpslpart.o > > obj-$(CONFIG_MTD_REDBOOT_PARTS) += redboot.o > > +obj-$(CONFIG_MTD_QCOMSMEM_PARTS) += qcomsmempart.o > > diff --git a/drivers/mtd/parsers/qcomsmempart.c b/drivers/mtd/parsers/qcomsmempart.c > > new file mode 100644 > > index 000000000000..d8c2a3fa4dfe > > --- /dev/null > > +++ b/drivers/mtd/parsers/qcomsmempart.c > > @@ -0,0 +1,169 @@ > > +// SPDX-License-Identifier: GPL-2.0-only > > +/* > > + * Qualcomm SMEM NAND flash partition parser > > + * > > + * Copyright (C) 2020, Linaro Ltd. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#define SMEM_AARM_PARTITION_TABLE 9 > > +#define SMEM_APPS 0 > > + > > +#define SMEM_FLASH_PART_MAGIC1 0x55ee73aa > > +#define SMEM_FLASH_PART_MAGIC2 0xe35ebddb > > +#define SMEM_FLASH_PTABLE_V3 3 > > +#define SMEM_FLASH_PTABLE_V4 4 > > +#define SMEM_FLASH_PTABLE_MAX_PARTS_V3 16 > > +#define SMEM_FLASH_PTABLE_MAX_PARTS_V4 48 > > +#define SMEM_FLASH_PTABLE_HDR_LEN (4 * sizeof(u32)) > > +#define SMEM_FLASH_PTABLE_NAME_SIZE 16 > > + > > +/** > > + * struct smem_flash_pentry - SMEM Flash partition entry > > + * @name: Name of the partition > > + * @offset: Offset in blocks > > + * @length: Length of the partition in blocks > > + * @attr: Flags for this partition > > + */ > > +struct smem_flash_pentry { > > + char name[SMEM_FLASH_PTABLE_NAME_SIZE]; > > + u32 offset; > > It would be nice if you noted that these are little endian (using > __le32) and used le32_to_cpu() below. > > Good catch! Will do. > Apart from that I think this looks really good. > [...] > > + } > > + > > + pr_debug("SMEM partition table found: ver: %d len: %d\n", > > + ptable->version, ptable->numparts); > > + *pparts = parts; > > + > > + return i; > > Had to check a few times, but afaict this is just ptable->numparts in > disguise... So how about just writing that instead? > Sure, will do. Thanks, Mani