From: Krzysztof Kozlowski <krzk@kernel.org>
To: Aisheng Dong <aisheng.dong@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
dl-linux-imx <linux-imx@nxp.com>, Bough Chen <haibo.chen@nxp.com>,
Ulf Hansson <ulf.hansson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>
Subject: Re: [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string
Date: Thu, 19 Nov 2020 16:25:35 +0100 [thread overview]
Message-ID: <20201119152535.GA386850@kozik-lap> (raw)
In-Reply-To: <AM6PR04MB49666B9100F4CE87E1AE23D680E00@AM6PR04MB4966.eurprd04.prod.outlook.com>
On Thu, Nov 19, 2020 at 03:21:59PM +0000, Aisheng Dong wrote:
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: Thursday, November 19, 2020 9:17 PM
> >
> > On Thu, Nov 19, 2020 at 08:53:02PM +0800, Dong Aisheng wrote:
> > > The compatible string "fsl,imx8qm-usdhc" was wrongly dropped in patch:
> > > 80fd350b9590 ("dt-bindings: mmc: fsl-imx-esdhc: Fix i.MX 8 compatible
> > > matching") Add it back.
> >
> > Although the compatible was dropped, by why wrongly? Please describe it.
> > The compatible is nowhere to be found, it is not used.
>
> The DT patch using it is still under review. So we need it.
It looks like other patches here follow similar process of sending
and applying dt-bindings separately from patches with users of these
bindings. Please don't do it like this. Send the bindings as the first
patch in the series implementing the users (so usually the series with
driver and DTS changes). The new bindings then are applied by the
driver subsystem maintainer.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-11-19 15:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 12:53 [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string Dong Aisheng
2020-11-19 12:53 ` [PATCH 2/3] dt-bindings: arm: fsl: add imx8qm boards " Dong Aisheng
2020-11-19 13:22 ` Krzysztof Kozlowski
2020-11-19 15:25 ` Aisheng Dong
2020-11-19 15:30 ` Krzysztof Kozlowski
2020-11-19 12:53 ` [PATCH 3/3] dt-bindings: mailbox: mu: add imx8qm support Dong Aisheng
2020-11-19 13:23 ` Krzysztof Kozlowski
2020-11-19 15:24 ` Aisheng Dong
2020-11-19 15:27 ` Krzysztof Kozlowski
2020-11-19 13:17 ` [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string Krzysztof Kozlowski
2020-11-19 15:21 ` Aisheng Dong
2020-11-19 15:25 ` Krzysztof Kozlowski [this message]
2020-11-23 12:28 ` Ulf Hansson
2020-11-24 7:02 ` Aisheng Dong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119152535.GA386850@kozik-lap \
--to=krzk@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=haibo.chen@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-mmc@vger.kernel.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).