Re: [PATCH 3/3] dt-bindings: mailbox: mu: add imx8qm support

[Krzysztof Kozlowski <krzk@kernel.org>]

On Thu, Nov 19, 2020 at 03:24:21PM +0000, Aisheng Dong wrote:
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: Thursday, November 19, 2020 9:23 PM
> > 
> > On Thu, Nov 19, 2020 at 08:53:04PM +0800, Dong Aisheng wrote:
> > > Add imx8qm support
> > >
> > > Cc: Rob Herring <robh+dt@kernel.org>
> > > Cc: devicetree@vger.kernel.org
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/mailbox/fsl,mu.yaml | 5 ++++-
> > >  1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > > b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > > index 15cef82cd356..1a3dff277e2b 100644
> > > --- a/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > > +++ b/Documentation/devicetree/bindings/mailbox/fsl,mu.yaml
> > > @@ -34,12 +34,15 @@ properties:
> > >                - fsl,imx8mm-mu
> > >                - fsl,imx8mn-mu
> > >                - fsl,imx8mp-mu
> > > +              - fsl,imx8qm-mu
> > 
> > You add the compatible below, so decide which one is it. Please provide also
> > users of this compatible - DTS.
> 
> There're two SCU MU protocol bindings, both can be used, just like exist fsl,imx8qxp-mu.

Makes sense. Still please send the bindings as first patch in series
implementing them. Upstream also the DTS with the bindings - the best in
the same series.

Best regards,
Krzysztof