devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Aisheng Dong <aisheng.dong@nxp.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	dl-linux-imx <linux-imx@nxp.com>,
	Rob Herring <robh+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>
Subject: Re: [PATCH 2/3] dt-bindings: arm: fsl: add imx8qm boards compatible string
Date: Thu, 19 Nov 2020 16:30:18 +0100	[thread overview]
Message-ID: <20201119153018.GA387077@kozik-lap> (raw)
In-Reply-To: <AM6PR04MB4966A53D856AF7A5B10107A780E00@AM6PR04MB4966.eurprd04.prod.outlook.com>

On Thu, Nov 19, 2020 at 03:25:38PM +0000, Aisheng Dong wrote:
> > From: Krzysztof Kozlowski <krzk@kernel.org>
> > Sent: Thursday, November 19, 2020 9:22 PM
> > 
> > On Thu, Nov 19, 2020 at 08:53:03PM +0800, Dong Aisheng wrote:
> > > Add imx8qm boards compatible string
> > >
> > > Cc: Rob Herring <robh+dt@kernel.org>
> > > Cc: devicetree@vger.kernel.org
> > > Cc: Shawn Guo <shawnguo@kernel.org>
> > > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/arm/fsl.yaml | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml
> > b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > index f793f90fe2e6..d69ac5c0554e 100644
> > > --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> > > @@ -726,6 +726,12 @@ properties:
> > >            - const: zii,imx8mq-ultra
> > >            - const: fsl,imx8mq
> > >
> > > +      - description: i.MX8QM based Boards
> > > +        items:
> > > +          - enum:
> > > +              - fsl,imx8qm-mek           # i.MX8QM MEK Board
> > 
> > No, please include the boards DTS in this patchset.
> 
> Good suggestion. Should I resend as DT patchset using it was also under review?

Patchsets bringing new boards should be organized like this one:
https://lore.kernel.org/lkml/20201107144811.1977108-1-aford173@gmail.com/

First the vendor prefix binding (skipped above), then the board binding
and finally DTS patches.

Best regards,
Krzysztof


  reply	other threads:[~2020-11-19 15:30 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-19 12:53 [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string Dong Aisheng
2020-11-19 12:53 ` [PATCH 2/3] dt-bindings: arm: fsl: add imx8qm boards " Dong Aisheng
2020-11-19 13:22   ` Krzysztof Kozlowski
2020-11-19 15:25     ` Aisheng Dong
2020-11-19 15:30       ` Krzysztof Kozlowski [this message]
2020-11-19 12:53 ` [PATCH 3/3] dt-bindings: mailbox: mu: add imx8qm support Dong Aisheng
2020-11-19 13:23   ` Krzysztof Kozlowski
2020-11-19 15:24     ` Aisheng Dong
2020-11-19 15:27       ` Krzysztof Kozlowski
2020-11-19 13:17 ` [PATCH 1/3] dt-bindings: mmc: imx: fix the wrongly dropped imx8qm compatible string Krzysztof Kozlowski
2020-11-19 15:21   ` Aisheng Dong
2020-11-19 15:25     ` Krzysztof Kozlowski
2020-11-23 12:28       ` Ulf Hansson
2020-11-24  7:02         ` Aisheng Dong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201119153018.GA387077@kozik-lap \
    --to=krzk@kernel.org \
    --cc=aisheng.dong@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).