From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B81BCC2D0E4 for ; Mon, 23 Nov 2020 17:14:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53CA520728 for ; Mon, 23 Nov 2020 17:14:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="l5q7W847" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733159AbgKWRO1 (ORCPT ); Mon, 23 Nov 2020 12:14:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:43574 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733152AbgKWRO1 (ORCPT ); Mon, 23 Nov 2020 12:14:27 -0500 Received: from localhost (unknown [122.171.203.152]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1D1D320719; Mon, 23 Nov 2020 17:14:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1606151667; bh=Z0D0G7UXZZita+xmedZvqpv4DisJLJYg0ajIZcOzBSM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=l5q7W847ripT143Funrq1sT9U76vY3E2WEZwTVwNMc1eh5l8aK10ltL1gxezscOtZ onto7fUrNGV8XlWu1BHq0poN7oQBNVUFjNWUtpnnoKoMizawr1FPxR2W7cF5Uv6qtg DfN0pit+2G73GnUJVaEvOBA7pX/SHQnqUUZRUNoY= Date: Mon, 23 Nov 2020 22:44:22 +0530 From: Vinod Koul To: Bjorn Andersson Cc: Andy Gross , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: sdm845: Add iommus property to qup Message-ID: <20201123171422.GE8403@vkoul-mobl> References: <20201122034149.626045-1-bjorn.andersson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201122034149.626045-1-bjorn.andersson@linaro.org> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 21-11-20, 19:41, Bjorn Andersson wrote: > From: Stephen Boyd > > The SMMU that sits in front of the QUP needs to be programmed properly > so that the i2c geni driver can allocate DMA descriptors. Failure to do > this leads to faults when using devices such as an i2c touchscreen where > the transaction is larger than 32 bytes and we use a DMA buffer. > > arm-smmu 15000000.iommu: Unexpected global fault, this could be serious > arm-smmu 15000000.iommu: GFSR 0x00000002, GFSYNR0 0x00000002, GFSYNR1 0x000006c0, GFSYNR2 0x00000000 > > Add the right SID and mask so this works. Reviewed-by: Vinod Koul on DB845c with GSI DMA: Tested-by: Vinod Koul -- ~Vinod