Devicetree
 help / color / mirror / Atom feed
From: Maxime Ripard <maxime@cerno.tech>
To: Chen-Yu Tsai <wens@csie.org>
Cc: Samuel Holland <samuel@sholland.org>,
	Michael Klein <michael@fossekall.de>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree <devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add gpio-poweroff to DT
Date: Tue, 24 Nov 2020 14:21:05 +0100	[thread overview]
Message-ID: <20201124132105.oai6gejdvdsnbzyx@gilmour> (raw)
In-Reply-To: <CAGb2v65=SoATrLDKvXH-EjdVJT3E4e+yQ6Ad0Nn1BQsB9aJvog@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]

On Tue, Nov 24, 2020 at 12:41:37PM +0800, Chen-Yu Tsai wrote:
> On Tue, Nov 24, 2020 at 12:14 PM Samuel Holland <samuel@sholland.org> wrote:
> >
> > On 11/23/20 10:10 AM, Michael Klein wrote:
> > > Add gpio-poweroff node to allow the board to power itself off after
> > > shutdown by disabling the SYSTEM and CPUX regulators (U5 resp. U6).
> > > The RST button can be used to restart the board.
> >
> > The PSCI client will override this driver once the PSCI implementation
> > is upgraded to v0.2 or newer functions. So having this around should
> > cause no compatibility issues (although it would print an error in dmesg
> > at that point). This seems like a reasonable thing to do for the other
> > H2+/H3 boards that use a similar regulator layout.
> 
> I wonder if this (gpio-poweroff) works if those regulators are also in the DT?

It's probably not going to probe at all, since both would claim the
exclusive usage of the GPIO?

I guess we should model this properly using the regulator framework, and
regulator_force_disable allows to bypass any usage count

Maxime

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

  reply	other threads:[~2020-11-24 13:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-23 16:10 [PATCH] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add gpio-poweroff to DT Michael Klein
2020-11-24  4:14 ` Samuel Holland
2020-11-24  4:41   ` Chen-Yu Tsai
2020-11-24 13:21     ` Maxime Ripard [this message]
2020-11-24 13:19 ` Maxime Ripard
2020-11-24 13:36   ` [PATCH v2] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add poweroff node " Michael Klein
2020-11-24 14:26     ` Maxime Ripard
2020-11-24 22:31       ` Michael Klein
2020-11-28 10:39         ` Maxime Ripard
2020-12-07 14:27           ` [PATCH v3 0/3] BPi M2 Zero poweroff support via new regulator-poweroff driver Michael Klein
2020-12-07 14:27             ` [PATCH v3 1/3] power: reset: new driver regulator-poweroff Michael Klein
2020-12-08 10:10               ` Maxime Ripard
2020-12-09 20:34                 ` Michael Klein
2020-12-07 14:27             ` [PATCH v3 2/3] Documentation: DT: binding documentation for regulator-poweroff Michael Klein
2020-12-08 10:13               ` Maxime Ripard
2020-12-08 12:52                 ` Michael Klein
2020-12-10 14:30                   ` Maxime Ripard
2020-12-08 15:21               ` Rob Herring
2020-12-08 15:39               ` Rob Herring
2020-12-07 14:27             ` [PATCH v3 3/3] ARM: dts: sun8i-h2-plus-bananapi-m2-zero: add poweroff node Michael Klein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201124132105.oai6gejdvdsnbzyx@gilmour \
    --to=maxime@cerno.tech \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@fossekall.de \
    --cc=robh+dt@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox