From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: Alex Elder <elder@ieee.org>
Cc: Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Alex Elder <elder@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sdm845: Limit ipa iommu streams
Date: Tue, 24 Nov 2020 13:49:03 -0600 [thread overview]
Message-ID: <20201124194903.GH185852@builder.lan> (raw)
In-Reply-To: <ecf7f5b6-a5ba-e370-d716-89272ad3c67b@ieee.org>
On Tue 24 Nov 13:18 CST 2020, Alex Elder wrote:
> On 11/22/20 11:23 PM, Bjorn Andersson wrote:
> > The Android and Windows firmware does not accept the use of 3 as a mask
> > to cover the IPA streams. But with 0x721 being related to WiFi and 0x723
> > being unsed the mapping can be reduced to just cover 0x720 and 0x722,
> > which is accepted.
>
> Do you want to update sc7180.dtsi too?
>
We probably want that too, but currently we don't have any sc7180
devices that shows this problem...
> I tried your change on my SDM845 machine and observed no
> problem. I tried the comparable change in "sc7180.dtsi"
> (using 440 and 442) and that seemed to work as before also.
>
> If you think that's sufficient, you can add:
>
> Tested-by: Alex Elder <elder@linaro.org>
>
> Otherwise:
>
> Acked-by: Alex Elder <elder@linaro.org>
>
Thank you,
Bjorn
>
> > Fixes: e9e89c45bfeb ("arm64: dts: sdm845: add IPA iommus property")
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
> > ---
> > arch/arm64/boot/dts/qcom/sdm845.dtsi | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > index 0da27b065761..a6147bd54cdf 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -2136,7 +2136,8 @@ ufs_mem_phy_lanes: lanes@1d87400 {
> > ipa: ipa@1e40000 {
> > compatible = "qcom,sdm845-ipa";
> > - iommus = <&apps_smmu 0x720 0x3>;
> > + iommus = <&apps_smmu 0x720 0x0>,
> > + <&apps_smmu 0x722 0x0>;
> > reg = <0 0x1e40000 0 0x7000>,
> > <0 0x1e47000 0 0x2000>,
> > <0 0x1e04000 0 0x2c000>;
> >
>
prev parent reply other threads:[~2020-11-24 19:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 5:23 [PATCH] arm64: dts: qcom: sdm845: Limit ipa iommu streams Bjorn Andersson
2020-11-24 19:18 ` Alex Elder
2020-11-24 19:49 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201124194903.GH185852@builder.lan \
--to=bjorn.andersson@linaro.org \
--cc=agross@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=elder@ieee.org \
--cc=elder@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).